🌱 Defaults for ConfigSpec CPU/mem alloc #902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures there are defaults for the ConfigSpec CPU/mem allocation fields for limits and shares. The documentation for a ResourceAllocation object states that all (VM) fields must be set for certain APIs, including ImportVApp. A part of that API is used by the vpxd placement engine to construct fake VMs in order to support assignable hardware. Therefore: CPU allocation: - Ensure limit is set to -1 if there is a reservation. Memory allocation: - Ensure shares is not nil. - Ensure limit is set to -1 if there is a reservation.
Minimum allowed line rate is |
bryanv
reviewed
Feb 21, 2025
| // Memory allocation: | ||
| // - Ensure shares is not nil. | ||
| // - Ensure limit is set to -1 if there is a reservation. | ||
| if a := configSpec.CpuAllocation; a != nil { |
There was a problem hiding this comment.
Does it make more sense to have these as a final } else { clause in the CPU or memory blocks above, since we're otherwise kind of spreading our defaulting logic out
There was a problem hiding this comment.
This way it handles it no matter how they started. That was intentional.
bryanv
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch ensures there are defaults for the ConfigSpec CPU/mem allocation fields for limits and shares.
The documentation for a ResourceAllocation object states that all (VM) fields must be set for certain APIs, including ImportVApp. A part of that API is used by the vpxd placement engine to construct fake VMs in order to support assignable hardware. Therefore:
CPU allocation:
Memory allocation:
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: