Remove jira::facts and rewrite upgrade logic #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now, I added an acceptance test that tries to test an upgrade scenario. I guess we might merge that into the "defaults" test so that there's less duplication. |
oranenj
force-pushed
the
remove-facts
branch
2 times, most recently
from
2415710 to
2f74d76
Compare
|
woop, it's green. I'll rebase and restore the other OSes, and let's see... |
Also test upgrade in acceptance
bastelfreak
approved these changes
Apr 21, 2021
|
Rebased to squish a bugfix on Ubuntu 18 (systemctl path). I also changed managehome to false for the jira user; that makes more sense, since we create the directory anyway and it will contain jira data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no need to depend on facts for upgrade.
We can bring the facts thing back if people really want it, but maybe after 5.0...