fix(compiler-sfc): don't inject scope id before child combinator > #13389

edison1105 · 2025-05-27T09:07:24Z

Summary by CodeRabbit

Bug Fixes
- Improved scoped CSS handling to correctly apply attribute selectors with child combinators (e.g., main > *), ensuring accurate style scoping.
Tests
- Added a test verifying proper scoping behavior for nested child selectors using combinators.

coderabbitai · 2025-05-27T09:07:55Z

Walkthrough

A new test was added to verify the correct handling of scoped CSS with direct child combinators and universal selectors. The implementation was updated to prevent attribute injection for selectors starting with a child combinator, while ensuring attribute selectors are still applied to trailing universal selectors, clarifying the control flow.

Changes

File(s)	Change Summary
packages/compiler-sfc/tests/compileStyle.spec.ts	Added a test for correct scoping of selectors using `main > *` with scoped attributes.
packages/compiler-sfc/src/style/pluginScoped.ts	Adjusted logic to prevent attribute injection after leading `>` combinator, and clarified universal selector handling.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant Compiler
    participant StylePlugin

    TestRunner->>Compiler: Compile SFC with scoped CSS (e.g., main > *)
    Compiler->>StylePlugin: Process selectors for scoping
    StylePlugin-->>Compiler: Inject attribute selectors appropriately
    Compiler-->>TestRunner: Return compiled CSS with correct scoping

Assessment against linked issues

Objective	Addressed	Explanation
Ensure CSS direct descendant wildcard rule (`> *`) is correctly scoped and applied to children (#13387)	✅

Possibly related PRs

fix(compiler-sfc): add scoping tag to trailing universal selector #12918: Refactored scoped attribute injection logic for universal selectors, which is further built upon by this PR.

Poem

A bunny hopped through CSS land,
Where selectors and stars go hand in hand.
With arrows and wildcards, the scope is now tight,
Children inherit styles, everything’s right!
Tests now ensure, with a hop and a cheer,
That your styles will appear just as you peer.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 522077b and 55ebbba.

📒 Files selected for processing (1)

packages/compiler-sfc/src/style/pluginScoped.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/compiler-sfc/src/style/pluginScoped.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Redirect rules
GitHub Check: Header rules
GitHub Check: Pages changed

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-05-27T09:08:45Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13389

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13389

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13389

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13389

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13389

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13389

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13389

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13389

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13389

vue

npm i https://pkg.pr.new/vue@13389

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13389

commit: 55ebbba

github-actions · 2025-05-27T09:08:50Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.3 kB	34.5 kB
vue.global.prod.js	159 kB	58.5 kB	52 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.6 kB	18.2 kB	16.7 kB
createApp	54.5 kB	21.2 kB	19.4 kB
createSSRApp	58.8 kB	23 kB	20.9 kB
defineCustomElement	59.5 kB	22.8 kB	20.8 kB
overall	68.6 kB	26.4 kB	24 kB

edison1105 · 2025-05-27T09:18:05Z

/ecosystem-ci run

vue-bot · 2025-05-27T09:25:12Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
language-tools	✅ success	✅ success
nuxt	✅ success	✅ success
test-utils	✅ success	✅ success
primevue	✅ success	✅ success
pinia	✅ success	✅ success
radix-vue	✅ success	✅ success
quasar	✅ success	✅ success
router	✅ success	✅ success
vant	✅ success	✅ success
vue-i18n	✅ success	✅ success
vue-macros	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
vuetify	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success
vitepress	✅ success	✅ success
vueuse	✅ success	✅ success

skirtles-code · 2025-05-28T00:23:26Z

More generally, why do we include the scope id earlier in the selector for * selectors?

e.g. Why does div * compile to div[data-v-7ba5bd90] [data-v-7ba5bd90] rather than div [data-v-7ba5bd90]? It seems strangely inconsistent that we scope the parent for div * but not div span.

I believe these 3 CSS rules should all be considered equivalent:

div > * {
  color: red;
}

div {
  > * {
    color: red;
  }
}

div {
  & > * {
    color: red;
  }
}

This PR seems like a step in the right direction, but the middle rule is still being handled differently from the other two.

skirtles-code · 2025-05-28T00:40:01Z

packages/compiler-sfc/src/style/pluginScoped.ts

+    // #13387 don't inject [id] at the selector start if node is null
+    // and the selector starts with `>`
+    const { type, value } = selector.first
+    if (type === 'combinator' && value === '>') {


Is there a reason to handle > differently from other combinators?

Other combinators can come first in a nested selector, see https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting#combinators. Combinators such as + seem to suffer from the same problem as > when used with *.

skirtles-code · 2025-05-28T21:05:00Z

I've created #13405 for further discussion of how to handle trailing * selectors.

edison1105 requested a review from Doctor-wu May 27, 2025 09:08

edison1105 added scope: sfc 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels May 27, 2025

edison1105 force-pushed the edison/fix/13387 branch from 4e0c3e9 to 9092ced Compare May 27, 2025 09:19

Doctor-wu approved these changes May 27, 2025

View reviewed changes

baiwusanyu-c approved these changes May 27, 2025

View reviewed changes

fix(compiler-sfc): don't inject scope id before child combinator >

522077b

edison1105 force-pushed the edison/fix/13387 branch from 9092ced to 522077b Compare May 27, 2025 09:28

edison1105 added the ready to merge The PR is ready to be merged. label May 27, 2025

skirtles-code reviewed May 28, 2025

View reviewed changes

chore: tweaks

55ebbba

edison1105 requested a review from skirtles-code May 28, 2025 01:26

edison1105 closed this May 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(compiler-sfc): don't inject scope id before child combinator > #13389

fix(compiler-sfc): don't inject scope id before child combinator > #13389

Uh oh!

edison1105 commented May 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 27, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 27, 2025

Uh oh!

edison1105 commented May 27, 2025

Uh oh!

vue-bot commented May 27, 2025

Uh oh!

skirtles-code commented May 28, 2025 •

edited

Loading

Uh oh!

skirtles-code May 28, 2025

Uh oh!

skirtles-code commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

fix(compiler-sfc): don't inject scope id before child combinator > #13389

fix(compiler-sfc): don't inject scope id before child combinator > #13389

Uh oh!

Conversation

edison1105 commented May 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 27, 2025

Size Report

Bundles

Usages

Uh oh!

edison1105 commented May 27, 2025

Uh oh!

vue-bot commented May 27, 2025

Uh oh!

skirtles-code commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skirtles-code May 28, 2025

Choose a reason for hiding this comment

Uh oh!

skirtles-code commented May 28, 2025

Uh oh!

Uh oh!

edison1105 commented May 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented May 27, 2025 •

edited

Loading

skirtles-code commented May 28, 2025 •

edited

Loading