Starting cg #4
Merged
Starting cg #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the dummy crate will be removed as soon as we have one real crate.
Tpt
approved these changes
Mar 17, 2025
| name: fmt | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
Cargo version is upgraded very quickly in Github images, not sure we need to bother with this
Having smart cargo cache with something like Swatinem/rust-cache might be more interesting
| with: | ||
| submodules: true | ||
| - run: cargo build --all-features | ||
| - run: cargo test --verbose --all --all-features |
There was a problem hiding this comment.
It might be nice to run tests and clippy without features to check that the feature gate are correct
| resolver = "3" | ||
|
|
||
| [workspace.package] | ||
| version = "0.1.0" |
There was a problem hiding this comment.
A discussion to have at some point: do we use the same version number for all crates or a version per crate?
| dummy = { version = "0.1.0", path = "dummy" } | ||
|
|
||
| [workspace.lints.clippy] | ||
| enum_glob_use = "allow" |
There was a problem hiding this comment.
Isn't this lint allow by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since workspaces must contain at least one package, this PR includes a dummy package which will be removed as soon as we have a real one in place.