Minimize line #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawka
reviewed
Aug 18, 2023
| @@ -155,10 +155,12 @@ class LineCmd extends React.Component<{screen : LineContainerModel, line : LineT | |||
| rtnStateDiffFetched : boolean = false; | |||
| lastHeight : number; | |||
| isOverflow : OV<boolean> = mobx.observable.box(false, {name: "line-overflow"}); | |||
| isMinimised : OV<boolean> = mobx.observable.box(false, {name: "line-minimised"}); | |||
sawka
reviewed
Aug 18, 2023
| isCmdExpanded : OV<boolean> = mobx.observable.box(false, {name: "cmd-expanded"}); | ||
|
|
||
| constructor(props) { | ||
| super(props); | ||
|
|
sawka
added a commit
that referenced
this pull request
Oct 16, 2023
* new remote file streaming API packets. implemented 'stat' for remote files * introduce filedata packets. allow streaming RPCs. fix RPC bug with combined packet parsers. implement file streaming for filestream RPC. * checkpoint on adding write-file * completely untested write-file impl -- writefilecontext, condition var for signaling new data packets, cleanup goroutine, ready/done states. * better error messages, also unlock MServer before calling done on wfcs * fix bug with perm json tag. change constant name
sawka
added a commit
that referenced
this pull request
Oct 16, 2023
* RPC for remote file streaming -- just implemented 'stat' for now (streaming to come) * allow RPC iterators for MShell RPCs. implement two test commands to test viewing files * implement read-file handler * read-file: allow overriding of content-type and use line's cwd not remote instance cwd * checkpoint on write-file impl * implemented metacommand version of write file * checkpoint, untested write-file impl * multipart handling for write-file data * add usetemp param to writefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I AM SURE IT DIDNT BREAK ANYTHING