Skip to content

Add button to mute audio when media is playing in webview #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2024
Merged

Add button to mute audio when media is playing in webview #1036

merged 2 commits into from
Oct 15, 2024

Conversation

esimkowitz
Copy link
Member

@esimkowitz esimkowitz commented Oct 15, 2024 •
edited
Loading

image

Also fixes atom usage for the url bar so it will properly update when any upstream atom states change

@esimkowitz esimkowitz merged commit 69c99dd into main Oct 15, 2024
4 checks passed
@esimkowitz esimkowitz deleted the evan/mutePlayb branch October 15, 2024 22:15
xxyy2024 pushed a commit to xxyy2024/waveterm_aipy that referenced this pull request Jun 24, 2025
@esimkowitz
Add button to mute audio when media is playing in webview (wavetermde…
99833c5 
…v#1036)

![image](https://github.com/user-attachments/assets/202636dc-aab5-4164-9729-fecd0cc804ae)

Also fixes atom usage for the url bar so it will properly update when
any upstream atom states change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@esimkowitz