Opening HelpView pages in external browser uses the public docsite equivalent #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxyy2024
pushed a commit
to xxyy2024/waveterm_aipy
that referenced
this pull request
Jun 24, 2025
…uivalent (wavetermdev#1289) Before, when you clicked the "Open in External Browser" button from the `HelpView`, the browser would attempt to open the embedded url, which may or may not still exist, depending on whether the content was cached from the last time the app was opened (since the embedded docsite uses a random port). Now, we'll swap the embedded url for the public docsite equivalent when you open in an external browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when you clicked the "Open in External Browser" button from the
HelpView, the browser would attempt to open the embedded url, which may or may not still exist, depending on whether the content was cached from the last time the app was opened (since the embedded docsite uses a random port). Now, we'll swap the embedded url for the public docsite equivalent when you open in an external browser.