-
Notifications
You must be signed in to change notification settings - Fork 372
Allow TestDriver to run on outside contributions #1622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
17cf7f7
68d6d49
b7deb9c
1bdee09
3ca8c36
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
name: TestDriver.ai Build | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
tags: | ||
- "v[0-9]+.[0-9]+.[0-9]+*" | ||
pull_request: | ||
branches: | ||
- main | ||
paths-ignore: | ||
- "docs/**" | ||
- ".storybook/**" | ||
- ".vscode/**" | ||
- ".editorconfig" | ||
- ".gitignore" | ||
- ".prettierrc" | ||
- ".eslintrc.js" | ||
- "**/*.md" | ||
schedule: | ||
- cron: 0 21 * * * | ||
workflow_dispatch: null | ||
|
||
env: | ||
GO_VERSION: "1.23" | ||
NODE_VERSION: 22 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Node.js version 22 is not recommended for this project The package.json files reveal that:
Using Node.js 22 (which is currently in development) could lead to compatibility issues. Node.js 20 is the current LTS version and would be more appropriate for production use. 🔗 Analysis chainVerify Node.js version compatibility Node.js version 22 is currently in development. Consider using the latest LTS version 20. - NODE_VERSION: 22
+ NODE_VERSION: 20 Let me verify the Node.js version compatibility by checking the project's dependencies and requirements. 🏁 Scripts executedThe following scripts were executed for the analysis: Error: No shell scripts found Script: #!/bin/bash
# Check for package.json files and their Node.js version requirements
fd package.json --exec cat {}
# Check for .nvmrc or .node-version files
fd -e nvmrc -e node-version --exec cat {}
# Look for any Node.js version specifications in workflow files
fd -e yml -e yaml -p '.github/workflows' --exec cat {}
Length of output: 8150 |
||
|
||
permissions: | ||
contents: read # To allow the action to read repository contents | ||
pull-requests: write # To allow the action to create/update pull request comments | ||
|
||
jobs: | ||
build_and_upload: | ||
name: Build for TestDriver.ai | ||
runs-on: windows-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
# General build dependencies | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version: ${{env.GO_VERSION}} | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{env.NODE_VERSION}} | ||
- name: Install Yarn | ||
uses: nick-fields/retry@v3 | ||
with: | ||
command: | | ||
corepack enable | ||
yarn install | ||
timeout_minutes: 5 | ||
max_attempts: 3 | ||
- name: Install Task | ||
uses: arduino/setup-task@v2 | ||
with: | ||
version: 3.x | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Build | ||
run: task package | ||
env: | ||
USE_SYSTEM_FPM: true # Ensure that the installed version of FPM is used rather than the bundled one. | ||
CSC_IDENTITY_AUTO_DISCOVERY: false # disable codesign | ||
shell: powershell # electron-builder's Windows code signing package has some compatibility issues with pwsh, so we need to use Windows Powershell | ||
Comment on lines
+61
to
+66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Enhance security for package task execution The
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.base.sha }}
|
||
|
||
# Upload .exe as an artifact | ||
- name: Upload .exe artifact | ||
id: upload | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: windows-exe | ||
path: make/*.exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid Go version specified
The Go version "1.23" is incorrect as it doesn't exist. The latest stable version is 1.22.
📝 Committable suggestion