Skip to content

Storybook with dark mode support #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .storybook/custom-addons/theme/register.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { FORCE_RE_RENDER } from "@storybook/core-events";
import { addons } from "@storybook/manager-api";
import { dark, light } from "../../theme";

addons.register("theme-switcher", (api) => {
const query = window.matchMedia("(prefers-color-scheme: dark)");
const update = () => {
const theme = query.matches ? dark : light;
api.setOptions({ theme });
addons.getChannel().emit(FORCE_RE_RENDER);
};

addons.getChannel().on("storiesConfigured", update);
query.addEventListener("change", update);
});
2 changes: 2 additions & 0 deletions .storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ const config: StorybookConfig = {
"@storybook/addon-essentials",
"@chromatic-com/storybook",
"@storybook/addon-interactions",
"storybook-dark-mode",
"./custom-addons/theme/register",
],

core: {},
Expand Down
6 changes: 0 additions & 6 deletions .storybook/manager.ts

This file was deleted.

29 changes: 29 additions & 0 deletions .storybook/preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ import "../frontend/app/theme.less";
import "../frontend/app/app.less";
import "../frontend/app/reset.less";
import "./global.css";
import { light, dark } from "./theme";
import { DocsContainer } from "@storybook/addon-docs";

import { addons } from "@storybook/preview-api";
import { DARK_MODE_EVENT_NAME } from "storybook-dark-mode";

const channel = addons.getChannel();

const preview: Preview = {
parameters: {
Expand All @@ -16,6 +23,28 @@ const preview: Preview = {
date: /Date$/i,
},
},
darkMode: {
dark,
light,
stylePreview: true,
classTarget: "html",
},
docs: {
container: (props) => {
const [isDark, setDark] = React.useState();

React.useEffect(() => {
channel.on(DARK_MODE_EVENT_NAME, setDark);
return () => channel.removeListener(DARK_MODE_EVENT_NAME, setDark);
}, [channel, setDark]);

return (
<div>
<DocsContainer {...props} theme={isDark ? dark : light} />
</div>
);
},
},
},

decorators: [
Expand Down
12 changes: 10 additions & 2 deletions .storybook/theme.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
import { create } from "@storybook/theming";

export default create({
export const light = create({
base: "light",
brandTitle: "Wave Terminal Storybook",
brandUrl: "https://www.waveterm.dev",
brandUrl: "https://storybook.waveterm.dev",
brandImage: "../assets/wave-light.png",
brandTarget: "_self",
});

export const dark = create({
base: "dark",
brandTitle: "Wave Terminal Storybook",
brandUrl: "https://storybook.waveterm.dev",
brandImage: "../assets/wave-dark.png",
brandTarget: "_self",
});
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"@storybook/react": "^8.3.3",
"@storybook/react-vite": "^8.3.3",
"@storybook/test": "^8.3.3",
"@storybook/theming": "^8.3.3",
"@types/css-tree": "^2",
"@types/debug": "^4",
"@types/electron": "^1.6.10",
Expand Down Expand Up @@ -66,6 +67,7 @@
"rollup-plugin-flow": "^1.1.1",
"semver": "^7.6.3",
"storybook": "^8.3.3",
"storybook-dark-mode": "^4.0.2",
"ts-node": "^10.9.2",
"tslib": "^2.6.3",
"tsx": "^4.19.1",
Expand Down
43 changes: 40 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1683,7 +1683,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/components@npm:^8.3.3":
"@storybook/components@npm:^8.0.0, @storybook/components@npm:^8.3.3":
version: 8.3.3
resolution: "@storybook/components@npm:8.3.3"
peerDependencies:
Expand All @@ -1692,6 +1692,15 @@ __metadata:
languageName: node
linkType: hard

"@storybook/core-events@npm:^8.0.0":
version: 8.3.3
resolution: "@storybook/core-events@npm:8.3.3"
peerDependencies:
storybook: ^8.3.3
checksum: 10c0/9ea51ec1b4c94d28e6bcb3b31dc21d98a4aa9685a0158ef42160f1934d6208db41b1461945b05fbe5dbb09fa629342c3576f4729f591b84471f70829bcbaf461
languageName: node
linkType: hard

"@storybook/core@npm:8.3.3":
version: 8.3.3
resolution: "@storybook/core@npm:8.3.3"
Expand Down Expand Up @@ -1750,6 +1759,16 @@ __metadata:
languageName: node
linkType: hard

"@storybook/icons@npm:^1.2.5":
version: 1.2.12
resolution: "@storybook/icons@npm:1.2.12"
peerDependencies:
react: ^16.8.0 || ^17.0.0 || ^18.0.0
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0
checksum: 10c0/97f6a7b7841fb5a0d1c8a30c36173469e7b0814a674c8103c7c0fd8803f0f7c2a778545af864012d40883195a533534dbc98541deac2bafe31e6a3fe37fdfc66
languageName: node
linkType: hard

"@storybook/instrumenter@npm:8.3.3":
version: 8.3.3
resolution: "@storybook/instrumenter@npm:8.3.3"
Expand All @@ -1763,7 +1782,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/manager-api@npm:^8.3.3":
"@storybook/manager-api@npm:^8.0.0, @storybook/manager-api@npm:^8.3.3":
version: 8.3.3
resolution: "@storybook/manager-api@npm:8.3.3"
peerDependencies:
Expand Down Expand Up @@ -1872,7 +1891,7 @@ __metadata:
languageName: node
linkType: hard

"@storybook/theming@npm:^8.3.3":
"@storybook/theming@npm:^8.0.0, @storybook/theming@npm:^8.3.3":
version: 8.3.3
resolution: "@storybook/theming@npm:8.3.3"
peerDependencies:
Expand Down Expand Up @@ -10292,6 +10311,22 @@ __metadata:
languageName: node
linkType: hard

"storybook-dark-mode@npm:^4.0.2":
version: 4.0.2
resolution: "storybook-dark-mode@npm:4.0.2"
dependencies:
"@storybook/components": "npm:^8.0.0"
"@storybook/core-events": "npm:^8.0.0"
"@storybook/global": "npm:^5.0.0"
"@storybook/icons": "npm:^1.2.5"
"@storybook/manager-api": "npm:^8.0.0"
"@storybook/theming": "npm:^8.0.0"
fast-deep-equal: "npm:^3.1.3"
memoizerific: "npm:^1.11.3"
checksum: 10c0/d4fc652ff080f6cc9f0effab0c989b66ead3372b267c2c328eef608f27c9822bf47aaa177405e42768b2de22f8a3e9a0280af50430efd0cf78bd6ed1f12c8b29
languageName: node
linkType: hard

"storybook@npm:^8.3.3":
version: 8.3.3
resolution: "storybook@npm:8.3.3"
Expand Down Expand Up @@ -11351,6 +11386,7 @@ __metadata:
"@storybook/react": "npm:^8.3.3"
"@storybook/react-vite": "npm:^8.3.3"
"@storybook/test": "npm:^8.3.3"
"@storybook/theming": "npm:^8.3.3"
"@table-nav/core": "npm:^0.0.7"
"@table-nav/react": "npm:^0.0.7"
"@tanstack/react-table": "npm:^8.20.5"
Expand Down Expand Up @@ -11423,6 +11459,7 @@ __metadata:
shell-quote: "npm:^1.8.1"
sprintf-js: "npm:^1.1.3"
storybook: "npm:^8.3.3"
storybook-dark-mode: "npm:^4.0.2"
throttle-debounce: "npm:^5.0.2"
tinycolor2: "npm:^1.6.0"
ts-node: "npm:^10.9.2"
Expand Down