Datasource for retrieving GCS service account #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishashchuk
force-pushed
the
data_gcs_account
branch
3 times, most recently
from
1262045 to
88790d3
Compare
ishashchuk
force-pushed
the
data_gcs_account
branch
from
88790d3 to
5628707
Compare
amoiseiev
reviewed
Feb 16, 2018
|
|
||
| The following attributes are exported: | ||
|
|
||
| * `id` - The ID of the service account, which is its email_address |
There was a problem hiding this comment.
any particular reason we need two attributes that are the same?
There was a problem hiding this comment.
All datasources have to have ID set, and that's how they get stored in state file. I wanted to have email_address as an additional attribute, since it's consistent with what API returns and with what people would probably be looking for intuitevely. No real reason to have "email_address", other than consistency with API. What do you think? Leave as is or remove it ?
|
Open upstream issue: hashicorp#1105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple datasource to get a GCS service account