Skip to content

Add indexNullState and indexPropertyLength field support in InvertedIndexConfig #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2023
Merged

Add indexNullState and indexPropertyLength field support in InvertedIndexConfig #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6155d08
feat: Add support for `indexNullState` field in InvertedIndexConfig
gauthamchandra May 18, 2023
389f6cd
feat: Add support for `indexPropertyLength` field in InvertedIndexConfig
gauthamchandra May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/io/weaviate/client/v1/misc/model/InvertedIndexConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,6 @@ public class InvertedIndexConfig {
StopwordConfig stopwords;
Integer cleanupIntervalSeconds;
Boolean indexTimestamps;
Boolean indexNullState;
Boolean indexPropertyLength;
}
56 changes: 56 additions & 0 deletions src/test/java/io/weaviate/integration/client/schema/ClientSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,62 @@ public void testCreateClassWithBM25Config() {
assertEquals(bm25Config.getK1(), bandClass.getResult().getInvertedIndexConfig().getBm25().getK1());
}

@Test
public void testCreateClassWithInvertedIndexContainingIndexNullState() {
// given
InvertedIndexConfig invertedIndexConfig = InvertedIndexConfig.builder()
.indexNullState(true)
.build();

WeaviateClass clazz = WeaviateClass.builder()
.className("Band")
.description("Band that plays and produces music")
.vectorIndexType("hnsw")
.vectorizer("text2vec-contextionary")
.invertedIndexConfig(invertedIndexConfig)
.build();

// when
Result<Boolean> createStatus = client.schema().classCreator().withClass(clazz).run();
Result<WeaviateClass> bandClass = client.schema().classGetter().withClassName(clazz.getClassName()).run();

// then
assertNotNull(createStatus);
assertTrue(createStatus.getResult());
assertNotNull(bandClass);
assertNotNull(bandClass.getResult());
assertNull(bandClass.getError());
assertTrue(bandClass.getResult().getInvertedIndexConfig().getIndexNullState());
}

@Test
public void testCreateClassWithInvertedIndexContainingIndexPropertyLength() {
// given
InvertedIndexConfig invertedIndexConfig = InvertedIndexConfig.builder()
.indexPropertyLength(true)
.build();

WeaviateClass clazz = WeaviateClass.builder()
.className("Band")
.description("Band that plays and produces music")
.vectorIndexType("hnsw")
.vectorizer("text2vec-contextionary")
.invertedIndexConfig(invertedIndexConfig)
.build();

// when
Result<Boolean> createStatus = client.schema().classCreator().withClass(clazz).run();
Result<WeaviateClass> bandClass = client.schema().classGetter().withClassName(clazz.getClassName()).run();

// then
assertNotNull(createStatus);
assertTrue(createStatus.getResult());
assertNotNull(bandClass);
assertNotNull(bandClass.getResult());
assertNull(bandClass.getError());
assertTrue(bandClass.getResult().getInvertedIndexConfig().getIndexPropertyLength());
}

@Test
public void testCreateClassWithStopwordsConfig() {
// given
Expand Down