Skip to content

Multi tenancy support (part 3) #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

aliszka
Copy link
Member

@aliszka aliszka commented Jul 6, 2023

No description provided.

@aliszka aliszka force-pushed the multi_tenancy_support_p3 branch from 41b2110 to 8da48c1 Compare July 6, 2023 19:18
@aliszka aliszka marked this pull request as ready for review July 6, 2023 19:28
Comment on lines +18 to +36
ErrorResponse errors;
String status;


@Getter
@ToString
@EqualsAndHashCode
@FieldDefaults(level = AccessLevel.PRIVATE)
public static class ErrorResponse {
List<ErrorItem> error;
}

@Getter
@ToString
@EqualsAndHashCode
@FieldDefaults(level = AccessLevel.PRIVATE)
public static class ErrorItem {
String message;
}
Copy link
Collaborator

@antas-marcin antas-marcin Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Comment on lines +63 to +70
switch (resp.getStatusCode()) {
case HttpStatus.SC_NO_CONTENT:
case HttpStatus.SC_NOT_FOUND:
return new Result<>(resp.getStatusCode(), resp.getStatusCode() == HttpStatus.SC_NO_CONTENT, resp.getErrors());
default:
WeaviateErrorResponse dummyError = WeaviateErrorResponse.builder().error(Collections.emptyList()).build();
return new Result<>(resp.getStatusCode(), resp.getStatusCode() == HttpStatus.SC_NO_CONTENT, dummyError);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@antas-marcin antas-marcin merged commit 9de7434 into main Jul 6, 2023
@antas-marcin antas-marcin deleted the multi_tenancy_support_p3 branch July 6, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants