Skip to content

fix(plugin-react): no chunk group of react if federation enabled #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

ScriptedAlchemy
Copy link
Contributor

Summary

Resolves chunk issue where excessive bloat is downloaded if federation is applied

Related Links

before:
image

after:
image

While more chunks are emitted, they are smaller and do not cause module duplication

Checklist

  • Tests updated.
  • Documentation updated.

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 39a2b74
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6603288ebd5532000836fa00
😎 Deploy Preview https://deploy-preview-1942--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 I will release a new version today

@chenjiahan chenjiahan merged commit 0bd2e5c into main Mar 27, 2024
@chenjiahan chenjiahan deleted the fix/module-federation-plugin-react-chunk-groupt branch March 27, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants