Skip to content

feat(plugin-sass): add useOriginalUrlResolver option to disable resolve-url-loader #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

junhea
Copy link
Contributor

@junhea junhea commented Jan 17, 2025

Summary

Adds new useOriginalUrlResolver option to disable resolve-url-loader

Related Links

Relative url usage like this should build

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 013bed7
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/678b464ff1fb9c000803c373
😎 Deploy Preview https://deploy-preview-4389--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 51 (🔴 down 23 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@junhea junhea changed the title feat(sass-plugin): add useOriginalUrlResolver option to skip resolve-url-loader feat(sass-plugin): add useOriginalUrlResolver option to disable resolve-url-loader Jan 17, 2025
@junhea junhea changed the title feat(sass-plugin): add useOriginalUrlResolver option to disable resolve-url-loader feat(plugin-sass): add useOriginalUrlResolver option to disable resolve-url-loader Jan 18, 2025
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, providing an option to opt-out resolve-url-loader might be useful. I want to redesign the naming of this API, I will submit a PR to update it later.

@chenjiahan chenjiahan merged commit 59709ef into web-infra-dev:main Jan 20, 2025
9 checks passed
@junhea junhea deleted the sass-plugin-use-original-url-resolver-option branch January 22, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants