-
-
Notifications
You must be signed in to change notification settings - Fork 650
perf: use mimalloc for musl target #6071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
!canary |
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
0.5.9-canary-df5312d-20240330095228 |
df5312d
to
16e548a
Compare
!canary |
0.5.9-canary-16e548a-20240330113014 |
b4c249e
to
ad947a6
Compare
ad947a6
to
c33ff59
Compare
!bench |
📝 Benchmark detail: Open
|
Seems like we can use mimalloc for everything. https://github.com/napi-rs/node-rs/blob/70d7fa72262c6e547950b30daa2d03583a1b04bd/crates/alloc/Cargo.toml |
yea it's good to make the allocator unified but i didn't make the change as i found it didn't help much on performance for glibc linked binary. and i need more effort to check if these change below works well. let me check if i got time later.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix the musl
performance issue first and try changing to mimalloc in another PR.
Summary
closes: #6072
related: #6065
linux musl binding now performs ~3x times faster than before.
sample of 0.5.9
sample of this change
Checklist