Skip to content

fix(modern-module): compat with more export cases #7394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Jul 31, 2024

Summary

  • Using module's concatenate bailout reason to filter out module to trigger force concatation.

  • Compat with export with a.b and (some_cjs()) final_name. Directly detecting invalid characters to fallback to module style export. It's not elegant, but I think it should work in most cases.

    var __webpack_exports__bar = (bar_default());
    export { foo, __webpack_exports__bar as bar };

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Jul 31, 2024
Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 71b1c2e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66ab1b111340390008bccbc0

@fi3ework fi3ework force-pushed the dsq-concat branch 2 times, most recently from 9d4d3cd to 338cfbe Compare July 31, 2024 17:44
@fi3ework fi3ework merged commit bd5135f into web-infra-dev:main Aug 1, 2024
30 checks passed
@chenjiahan chenjiahan mentioned this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants