Skip to content

Commit 10ac938

Browse files
domenicchromium-wpt-export-bot
authored andcommitted
Minimal rename of Origin-Isolation
This CL renames the Origin-Isolation header to Origin-Agent-Cluster, and the window.originIsolated getter to window.originAgentCluster, following whatwg/html#6214. See Intent to Ship update at https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI/m/bwxj0iiYAgAJ This only does the minimal renames necessary to update web-facing semantics, and then the minimal modifications to the tests to get them passing again. Future CLs on top of this one should: * Update all code references (e.g. function and member names) to stop saying "origin isolation". * Update all test titles, comments, etc. * Move the tests to a new directory. Bug: 1157917 Change-Id: I1f95eb3d5298a6dfae3d3bda4a79343e8287d4f6
1 parent 6befc77 commit 10ac938

File tree

44 files changed

+52
-45
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+52
-45
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1

origin-isolation/README.md

Lines changed: 7 additions & 0 deletions
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
Content-Security-Policy: sandbox allow-scripts;
2-
Origin-Isolation: ?1
2+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1

origin-isolation/getter-special-cases/removed-iframe.sub.https.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020

2121
const frameWindow = iframe.contentWindow;
2222

23-
assert_equals(frameWindow.originIsolated, true, "before");
23+
assert_equals(frameWindow.originAgentCluster, true, "before");
2424
iframe.remove();
25-
assert_equals(frameWindow.originIsolated, true, "after");
25+
assert_equals(frameWindow.originAgentCluster, true, "after");
2626
}, "Removing the iframe does not change originIsolated");
2727
</script>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1

origin-isolation/getter-special-cases/resources/helpers.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export async function insertCustomIframe(src) {
2323
export const testSupportScript = `
2424
<script>
2525
window.onmessage = () => {
26-
parent.postMessage(self.originIsolated, "*");
26+
parent.postMessage(self.originAgentCluster, "*");
2727
};
2828
</script>
2929
`;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Origin-Isolation: ?1
1+
Origin-Agent-Cluster: ?1

origin-isolation/resources/helpers.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ export function testGetter(testFrame, expected, testLabelPrefix) {
272272

273273
promise_test(async () => {
274274
if (testFrame === self) {
275-
assert_equals(self.originIsolated, expected);
275+
assert_equals(self.originAgentCluster, expected);
276276
} else if (typeof testFrame === "number") {
277277
const frameWindow = frames[testFrame];
278278
const result = await accessOriginIsolated(frameWindow);

origin-isolation/resources/send-header-page-script.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ window.onmessage = async (e) => {
1818
document.domain = e.data.newDocumentDomain;
1919
e.source.postMessage("document.domain is set", "*");
2020
} else if (e.data.command === "get originIsolated") {
21-
e.source.postMessage(self.originIsolated, "*");
21+
e.source.postMessage(self.originAgentCluster, "*");
2222
}
2323

2424
// These only come from the parent.

origin-isolation/resources/send-origin-isolation-header.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
def main(request, response):
2-
"""Send a response with the Origin-Isolation header given in the "header"
2+
"""Send a response with the Origin-Agent-Cluster header given in the "header"
33
query parameter, or no header if that is not provided. Other query
44
parameters (only their presence/absence matters) are "send-loaded-message"
55
and "redirect-first", which modify the behavior a bit.
@@ -29,7 +29,7 @@ def main(request, response):
2929

3030
if b"header" in request.GET:
3131
header = request.GET.first(b"header")
32-
response.headers.set(b"Origin-Isolation", header)
32+
response.headers.set(b"Origin-Agent-Cluster", header)
3333

3434
response.headers.set(b"Content-Type", b"text/html")
3535

0 commit comments

Comments
 (0)