Rename `Origin-Isolation` to `Origin-Agent-Cluster` #6214

domenic · 2020-12-10T21:01:59Z

Also renames the feature from "origin isolation" to "origin-keyed agent
clusters" and renames the getter from window.originIsolated to
window.originAgentCluster.

Closes #6192.

At least two implementers are interested (and none opposed):
- Chrome
- Firefox per Renaming the Origin-Isolation header #6192.
Tests are written and can be reviewed and commented upon at:
- Initial test updates at https://chromium-review.googlesource.com/c/chromium/src/+/2587369 , which will auto-export soon
- Further test updates (to fix all the comments and rename the directory and such) will follow.
Implementation bugs are filed:
- Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=1157917
- Firefox: will update https://bugzilla.mozilla.org/show_bug.cgi?id=1665474
- Safari: will update https://bugs.webkit.org/show_bug.cgi?id=216618

(See WHATWG Working Mode: Changes for more details.)

/browsers.html ( diff )
/browsing-the-web.html ( diff )
/iana.html ( diff )
/index.html ( diff )
/origin.html ( diff )
/webappapis.html ( diff )
/window-object.html ( diff )

Also renames the feature from "origin isolation" to "origin-keyed agent clusters" and renames the getter from window.originIsolated to window.originAgentCluster. Closes #6192.

sideshowbarker · 2020-12-11T07:39:21Z

source


   <dd>
-    <p>Returns true if this <code>Window</code> is origin-isolated in the manner described in this
-    section.</p>
+    <p>Returns true if this <code>Window</code> is belongs to an <span>agent cluster</span> which is


Suggested change

Returns true if this <code>Window</code> is belongs to an agent cluster which is

Returns true if this <code>Window</code> belongs to an agent cluster which is

Mainly to avoid giving the impression it's a hard guarantee with regards to Spectre. See whatwg/html#6214.

This CL renames the Origin-Isolation header to Origin-Agent-Cluster, and the window.originIsolated getter to window.originAgentCluster, following whatwg/html#6214. See Intent to Ship update at https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI/m/bwxj0iiYAgAJ This only does the minimal renames necessary to update web-facing semantics, and then the minimal modifications to the tests to get them passing again. Future CLs on top of this one should: * Update all code references (e.g. function and member names) to stop saying "origin isolation". * Update all test titles, comments, etc. * Move the tests to a new directory. Bug: 1157917 Change-Id: I1f95eb3d5298a6dfae3d3bda4a79343e8287d4f6

This CL renames the Origin-Isolation header to Origin-Agent-Cluster, and the window.originIsolated getter to window.originAgentCluster, following whatwg/html#6214. See Intent to Ship update at https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI/m/bwxj0iiYAgAJ This only does the minimal renames necessary to update web-facing semantics, and then the minimal modifications to the tests to get them passing again. Future CLs on top of this one should: * Update all code references (e.g. function and member names) to stop saying "origin isolation". * Update all test titles, comments, etc. * Move the tests to a new directory. Bug: 1157917 Change-Id: I1f95eb3d5298a6dfae3d3bda4a79343e8287d4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587369 Commit-Queue: Domenic Denicola <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/master@{#836413}

Mainly to avoid giving the impression it's a hard guarantee with regards to Spectre. See whatwg/html#6214. (It's now Origin-Keyed Agent Clusters.)

Follows whatwg/html#6214.

…stonly Automatic update from web-platform-tests Minimal rename of Origin-Isolation This CL renames the Origin-Isolation header to Origin-Agent-Cluster, and the window.originIsolated getter to window.originAgentCluster, following whatwg/html#6214. See Intent to Ship update at https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI/m/bwxj0iiYAgAJ This only does the minimal renames necessary to update web-facing semantics, and then the minimal modifications to the tests to get them passing again. Future CLs on top of this one should: * Update all code references (e.g. function and member names) to stop saying "origin isolation". * Update all test titles, comments, etc. * Move the tests to a new directory. Bug: 1157917 Change-Id: I1f95eb3d5298a6dfae3d3bda4a79343e8287d4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587369 Commit-Queue: Domenic Denicola <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/master@{#836413} -- wpt-commits: 90a1381e3736eca4700c1b08fee8f313fea20593 wpt-pr: 26867

…stonly Automatic update from web-platform-tests Minimal rename of Origin-Isolation This CL renames the Origin-Isolation header to Origin-Agent-Cluster, and the window.originIsolated getter to window.originAgentCluster, following whatwg/html#6214. See Intent to Ship update at https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI/m/bwxj0iiYAgAJ This only does the minimal renames necessary to update web-facing semantics, and then the minimal modifications to the tests to get them passing again. Future CLs on top of this one should: * Update all code references (e.g. function and member names) to stop saying "origin isolation". * Update all test titles, comments, etc. * Move the tests to a new directory. Bug: 1157917 Change-Id: I1f95eb3d5298a6dfae3d3bda4a79343e8287d4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587369 Commit-Queue: Domenic Denicola <domenicchromium.org> Reviewed-by: Charlie Reis <creischromium.org> Reviewed-by: Chris Harrelson <chrishtrchromium.org> Cr-Commit-Position: refs/heads/master{#836413} -- wpt-commits: 90a1381e3736eca4700c1b08fee8f313fea20593 wpt-pr: 26867 UltraBlame original commit: 9e97298a0b7bff8e9c0c88eb2ccf1b50faaecce7

…stonly Automatic update from web-platform-tests Minimal rename of Origin-Isolation This CL renames the Origin-Isolation header to Origin-Agent-Cluster, and the window.originIsolated getter to window.originAgentCluster, following whatwg/html#6214. See Intent to Ship update at https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI/m/bwxj0iiYAgAJ This only does the minimal renames necessary to update web-facing semantics, and then the minimal modifications to the tests to get them passing again. Future CLs on top of this one should: * Update all code references (e.g. function and member names) to stop saying "origin isolation". * Update all test titles, comments, etc. * Move the tests to a new directory. Bug: 1157917 Change-Id: I1f95eb3d5298a6dfae3d3bda4a79343e8287d4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587369 Commit-Queue: Domenic Denicola <[email protected]> Reviewed-by: Charlie Reis <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/master@{#836413} -- wpt-commits: 90a1381e3736eca4700c1b08fee8f313fea20593 wpt-pr: 26867

Rename Origin-Isolation to Origin-Agent-Cluster

478a380

Also renames the feature from "origin isolation" to "origin-keyed agent clusters" and renames the getter from window.originIsolated to window.originAgentCluster. Closes #6192.

domenic requested a review from annevk December 10, 2020 21:02

sideshowbarker reviewed Dec 11, 2020

View reviewed changes

annevk approved these changes Dec 11, 2020

View reviewed changes

annevk added a commit to mozilla/standards-positions that referenced this pull request Dec 11, 2020

Origin Isolation is being renamed

9150881

Mainly to avoid giving the impression it's a hard guarantee with regards to Spectre. See whatwg/html#6214.

annevk mentioned this pull request Dec 11, 2020

Origin Isolation is being renamed mozilla/standards-positions#465

Merged

Fix extra word, thanks Mike!

0eb99cc

domenic merged commit f5628b9 into master Dec 11, 2020

domenic deleted the rename-origin-isolation branch December 11, 2020 20:40

chromium-wpt-export-bot mentioned this pull request Dec 11, 2020

Minimal rename of Origin-Isolation web-platform-tests/wpt#26867

Merged

annevk added a commit to mozilla/standards-positions that referenced this pull request Dec 14, 2020

Origin Isolation is being renamed

46d537d

Mainly to avoid giving the impression it's a hard guarantee with regards to Spectre. See whatwg/html#6214. (It's now Origin-Keyed Agent Clusters.)

domenic added a commit to domenic/origin-agent-cluster-demo.dev that referenced this pull request Dec 14, 2020

Update for the rename

eca84d0

Follows whatwg/html#6214.

neoncitylights mentioned this pull request Apr 27, 2025

HTTP field Origin-Agent-Cluster, from WHATWG HTML Standard mdn/mdn#667

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename `Origin-Isolation` to `Origin-Agent-Cluster` #6214

Rename `Origin-Isolation` to `Origin-Agent-Cluster` #6214

Uh oh!

domenic commented Dec 10, 2020 •

edited

Loading

Uh oh!

sideshowbarker Dec 11, 2020

Uh oh!

Uh oh!

	<p>Returns true if this <code>Window</code> is belongs to an <span>agent cluster</span> which is
	<p>Returns true if this <code>Window</code> belongs to an <span>agent cluster</span> which is

Rename Origin-Isolation to Origin-Agent-Cluster #6214

Rename Origin-Isolation to Origin-Agent-Cluster #6214

Uh oh!

Conversation

domenic commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sideshowbarker Dec 11, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Rename `Origin-Isolation` to `Origin-Agent-Cluster` #6214

Rename `Origin-Isolation` to `Origin-Agent-Cluster` #6214

domenic commented Dec 10, 2020 •

edited

Loading