Skip to content

Clean up DisableAhemAntialias #51566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2025
Merged

Clean up DisableAhemAntialias #51566

merged 2 commits into from
Mar 26, 2025

Conversation

tcaptan-cr
Copy link
Contributor

This feature was removed (in [1]) because it was no longer needed since font antialiasing is disabled on all test platforms.

[1]
https://crrev.com/c/chromium/src/+/6370105

@tcaptan-cr
Clean up DisableAhemAntialias
826e8cc 
This feature was removed (in [1]) because it was no longer
needed since font antialiasing is disabled on all test platforms.

[1]
https://crrev.com/c/chromium/src/+/6370105
@tcaptan-cr tcaptan-cr requested a review from WeizhongX March 24, 2025 23:41
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Mar 24, 2025
@WeizhongX
Copy link
Contributor

The failure on infrastructure/tests is not related with this change. Failure logs from the builder copied below:

Unexpected Results

/infrastructure/assumptions/canvas-background.html
CRASH /infrastructure/assumptions/canvas-background.html
/infrastructure/reftest/reftest.www.sub.html
CRASH /infrastructure/reftest/reftest.www.sub.html
/infrastructure/reftest/reftest_ref_timeout.html
CRASH /infrastructure/reftest/reftest_ref_timeout.html
/infrastructure/reftest/reftest_timeout.html
CRASH /infrastructure/reftest/reftest_timeout.html
/infrastructure/reftest/reftest_wait_0.html
TIMEOUT /infrastructure/reftest/reftest_wait_0.html - TestRunner hit external timeout (this may indicate a hang)
5:42.17 INFO Got 5 unexpected results, with 0 unexpected passes

@WeizhongX
Copy link
Contributor

@KyleJu can you help admin merge this? Thanks!

@KyleJu KyleJu merged commit 7ffff28 into master Mar 26, 2025
31 of 33 checks passed
@KyleJu KyleJu deleted the CleanUpDisableAhemAntialias branch March 26, 2025 20:36
mohamedamir pushed a commit to mohamedamir/wpt that referenced this pull request Mar 27, 2025
@tcaptan-cr @mohamedamir
Clean up DisableAhemAntialias (web-platform-tests#51566)
cbd6dc8 
* Clean up DisableAhemAntialias

This feature was removed (in [1]) because it was no longer
needed since font antialiasing is disabled on all test platforms.

[1]
https://crrev.com/c/chromium/src/+/6370105

* Define blink_features at use time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleJu KyleJu KyleJu approved these changes

@WeizhongX WeizhongX WeizhongX approved these changes

@DanielRyanSmith DanielRyanSmith Awaiting requested review from DanielRyanSmith

@foolip foolip Awaiting requested review from foolip

@jgraham jgraham Awaiting requested review from jgraham

Assignees

@jgraham jgraham

Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tcaptan-cr @WeizhongX @KyleJu @jgraham @wpt-pr-bot