Skip to content

Disable duplicating and deleting folders in content mode #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kof opened this issue Mar 23, 2025 · 3 comments · Fixed by #5083
Closed

Disable duplicating and deleting folders in content mode #5038

kof opened this issue Mar 23, 2025 · 3 comments · Fixed by #5083
Assignees
@Blazing-Mike
Labels
complexity:low Good for newcomers, up to a few days of work prio:1 The most important thing to work on type:feat Features and enhancements

Comments

@kof
Copy link
Member

kof commented Mar 23, 2025

This is an oversight and should be disabled.
@kof kof added complexity:low Good for newcomers, up to a few days of work type:feat Features and enhancements prio:1 The most important thing to work on labels Mar 23, 2025
@Blazing-Mike
Copy link
Contributor

Blazing-Mike commented Apr 1, 2025 •
edited
Loading

I wanna to work on this. should the delete icon be removed from the UI completed or disabled (faded).

leaning towards removing from the UI completely though. Also this should be both folders and pages right.

@kof
Copy link
Member Author

kof commented Apr 1, 2025

@Blazing-Mike Ok, will assign it to you

@Blazing-Mike
Copy link
Contributor

ok here, removed the delete and duplicate button if its not design mode.

Screen.Recording.2025-04-01.at.10.16.45.PM.mov

@Blazing-Mike Blazing-Mike mentioned this issue Apr 2, 2025
Merged
6 tasks
TrySound pushed a commit that referenced this issue Apr 3, 2025
@Blazing-Mike
fix: render delete icon only in design mode for folder settings and d…
38678a4 
…uplicate icon for page settings #5038 (#5083)

fixes: #5038 

## Description
delete button shows on folder settings in content mode and duplicate
button shows for page setting. this fix removes these buttons in content
mode.

1. What is this PR about (link the issue and add a short description)

## Steps for reproduction

1. switch to content mode on your project
2. got to page/folder settings
3. expect that duplicate icon/delete icon should not be visible
4. 
## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [x] made a self-review
- [x] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [x] tested locally and on preview environment (preview dev login:
0000)
- [] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Blazing-Mike Blazing-Mike

Labels
complexity:low Good for newcomers, up to a few days of work prio:1 The most important thing to work on type:feat Features and enhancements
Projects
None yet
Milestone
No milestone
2 participants
@kof @Blazing-Mike