Skip to content

fix: reset spacing values with alt-click #5053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

fix: reset spacing values with alt-click #5053

merged 1 commit into from
Mar 26, 2025

Conversation

kof
Copy link
Member

@kof kof commented Mar 26, 2025

Description

When alt-clicking on the label in spacing, reset the value

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof
Copy link
Member Author

kof commented Mar 26, 2025

I am sure we changed this behavior not long ago but I can't figure out why, because the implementation seems simple and it works

@TrySound
Copy link
Member

Probably broken because of alt modifier used for opposite side highlighting. Btw shift+alt+click resets all.

@kof kof merged commit 0597c4f into main Mar 26, 2025
17 checks passed
@kof kof deleted the reset-spacing branch March 26, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants