Skip to content

feat: add close button for popover element #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

JayaKrishnaNamburu
Copy link
Contributor

fixes #3988

Description

This PR adds PopoverClose button to Popover element. Just exported and added the component from @radix-ui/popover. Which is where all the rest of the elements are being used.

Existing project on staging - https://p-33460026-be01-4d80-8f4f-1d6677c38fe0-dot-pop-close.staging.webstudio.is
Deployed project on staging - https://jk-popover-close-1ph18.wstd.work

popover-close

Steps for reproduction

  • You can go to staging, and create a project with popover.
  • Deploy the project and checked the rendered popover

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review

Before merging

  • tested locally and on preview environment (preview dev login: 0000)

Copy link
Member

@TrySound TrySound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit 24efd92 into main May 14, 2025
29 checks passed
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the pop-close.staging branch May 14, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover has no close button
2 participants