-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add version response & cli command #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test would be nice to have, especially since it would have caught an env!
crash without a review.
The cargo build script now creates the version file for the bot. This way it doesn't panic if it's not run with cargo and the tarball will have the version available as it is copied from the bot-data folder. |
Fine code-wise, I'm not approving yet because I want to test this first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a test and a fix commit to this branch
@Septias I rebased the branch but now GH displays only the commiter (me) because you don't have your email confirmed with GH. |
95f31a3
to
393e3e4
Compare
Ok, there is a problem introduced in #29 (see comment #29 (comment)) still there. And if you actually set these variables, output of
EDIT: fixed this too |
Can we squash merge and just manually add me? |
Looks good to me, you can merge if you want. |
The file with `git describe` output already contains a newline.
closes #41
closes #50
This pr parses every message received for the
/version
command. Because the msg is loaded then anyway, this creates room for improvements because the msg will be loaded in the respective handlers again atm.