-
Notifications
You must be signed in to change notification settings - Fork 94
Integrate WildFly calendar #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @hpehl - I do like the calendar being available, but seeing it on the same page as the conferences I am not certain about (personally). That being said, it does look to render as I would expect and so I will add my +1 review as my remark is perhaps a matter of personal preference. Thanks for inviting my review! |
Yeah, I know what you're getting at. The problem is that both the events as well as the calendar should be available from the header. And space is limited in the header. I'm open for any suggestions how we could improve this! |
I think a TOC or some UI element that serves a similar purpose is needed at the top. Maybe a brief intro section. If you open the page in a big enough window you might see and notice the WildFly Conferences section; otherwise you just see the calendar. For sure that's the case on a phone. And most of the time the calendar isn't going to be enticing. |
Tangent, not an controllable by this PR: the calendar says times are in US central time, which I didn't think was how it is set up. I'll have a look. |
Never mind re the TZ thing. Looking at the PR code I see that's a Feature not a Bug. It knows my TZ. Well done. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open for any suggestions how we could improve this!
A dropdown menu entry?
It knows my TZ. Well done. :-)
Yes, well done @hpehl , looks good in my environment with the expected TZ, and renders pretty well.
I share Tom's feedback about getting both the calendar and conferences on the same page.
@bstansberry, @tomjenkinson, @yersan I've added a sidebar with a TOC to the events page. Still not 100% satisfied, but better than the initial layout. |
It's definitely better to have that - thank you. I am if adding a variant of that could also be part of the body of the page as (at least for me) I think maybe because I am seeing "WildFly Calendar" first in such a large font that I might be expecting the whole page to be about that and possibly some people may not decide to scroll further? E.g. |
Thanks @tomjenkinson, that's a good point. I've changed the page to use different headings and added an intro section. |
Excellent - thank you @hpehl ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too
_layouts/events.html
Outdated
<a href="#wildfly-conferences">WildFly Conferences</a> | ||
<ul> | ||
<li><a href="#next-events">Next Events</a></li> | ||
<li><a href="#previous-events">Previous Events</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps for the visible text
Upcoming
Previous
- "Previous Events" ends up on two lines for me so it doesn't look crisp.
- In L6 above, the h1 summary block text is "WildFly Events", a broader category, while these TOC items just to the right are about Conferences. So there's cognitive dissonance having the word Event there. Is it the Next Event of all types? No; it's the Next Event of the WildFly Conference type.
Note that I think the existing use of Next Event / Previous Events in the section titles further down in the WildFly Conferences section is fine. By then the reader is past the h1 title and the calendar and in the WildFly Conference section, so there's no confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bstansberry for the feedback. That makes perfect sense!
Note I looked at this on my phone and it looks good. |
Thanks all for your input. The new calendar is now live at https://www.wildfly.org/events/#calendar. I've posted about it on Fosstodon: https://www.wildfly.org/events/#calendar. Feel free to boost it. |
This PR adds the WildFly calendar to wildfly.org/events
A preview is available here: https://hpehl.github.io/wildfly.org/events/