editor.js, widget.py trix 2.0.0 #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parisk
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Thanks a lot for your contribution @onno-timmerman! I know it took quite a while to respond, but now I got the chance to review everything. I updated a few things:
- Removed the custom
keyin the front-end, since it's ignored in the backend - Double checked that Trix 2.0 works fine
- Created a new global window JavaScript object to act as a namespace;
djangoProse - Formatted JavaScript code and added CI tests
- Fixed CI to work for Pull Requests from forks.
LGTM 🦘
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem with using the prose and htmx to upload a file. If you htmx load the editor the editor.js isn't working. This needs to be initialized again. So now you can initialize it in a easy way. Maybe there should be something in the docs about it as HTMX is fast getting popular in Django world.
Out of curiosity I tried to bump trix to 2.0.0 and all seems to work fine.
Please double test my code before merging.