-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Playlists always append an "on:true" #4557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this is the default behaviour. why cant you just delete the "on:true" from the playlist if you dont need it? |
That is the isdue: If i delete that part it will be added again after vsave |
ah I see, can confirm that. I do not know the reason it is that way but it looks like it is intentional. |
It is intentional. |
Some of the guys reported that multiple times on discord and not really sure of the intended reasoning for it as if you |
Why are we forcing on:true if the user did not request? |
Thanks, that is what i also thought. Playlists could be more flexible wirhout forcing on the main output. Maybe move to feature requests? |
User did request. In a lost post on Discord, quite a while ago. |
Would be great to understand the reason instead of moving back and forth. In my eyes rhe json of a playlist should be saved as you modified it - with or wirhout that "on" statement |
sorry, lazy wording. When I said user i was meaning that if the user had not selected something in the UI to set on:true, rather than a feature request from a user |
Let me put it other way:
WLED's playlist work only if WLED state is on at the start of playlist. |
Right. But that would work since the presets contains only settings like multirelays--Gesendet von meinem C64Am 16.03.25, 16:14 schrieb "Blaž Kristan" ***@***.***>:
Let me put it other way:
user creates presets without saving brightness
user creates playlist of such presets
user selects such playlist and WLED is in off state
nothig happens
WLED's playlist work only if WLED state is on at the start of playlist.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
blazoncek left a comment (wled/WLED#4557)
Let me put it other way:
user creates presets without saving brightness
user creates playlist of such presets
user selects such playlist and WLED is in off state
nothig happens
WLED's playlist work only if WLED state is on at the start of playlist.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
No, it wouldn't. |
Yeah the use/abuse of presets and playlists for things other than LED output does rather muddy the waters a bit. I think you are probably right that in that scenario users might expect the lights to turn on even if the playlist entries themselves were saved without brightness. Adding a tick box to the UI for the playlist would be the ideal solution, but feels low priority. If others wish to submit a PR, great, but agree this isn't a bug |
What happened?
My goal is to realize a secure relay timer on an GPIO (external multirelay pin). I did a playlist like:
but after saving this to the presets it will be appendend by an "on:true", but i don't want the main power to come up too.
To Reproduce Bug
see above
Expected Behavior
a playlist without "on:true"
Install Method
Binary from WLED.me
What version of WLED?
WLED 0.15.0
Which microcontroller/board are you seeing the problem on?
ESP32
Relevant log/trace output
Anything else?
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: