Skip to content

Allow more compile time settings for multi-relay #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

chrisburrows
Copy link

A small change to allow more characteristics of the relays to be set at compile time. Useful if you have a standard hardware build / config across multiple WLED instances (e.g. always use the same pin for a relay).

@blazoncek
Copy link
Collaborator

Please re-base your PR to 0_14_1 or 0_15 branch.

@blazoncek blazoncek changed the base branch from main to 0_15 November 7, 2023 16:14
Copy link
Collaborator

@blazoncek blazoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C++ code is ok, but the changes in readme.md require some updates.
Please also add changelog at the end of readme (and include your info for future reference).

@@ -47,6 +47,19 @@ or

You can override the default maximum number of relays (which is 4) by defining MULTI_RELAY_MAX_RELAYS.

Some settings can be defined (defaults) at compile time by setting the following defines:

MULTI_RELAY_HA_DISCOVERY true or false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes do not render correctly when viewed as a document (i.e. viewed on Github).

@blazoncek blazoncek merged commit 0739cfc into wled:0_15 Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants