Skip to content

bugfix in enumerating buttons and busses #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

DedeHai
Copy link
Collaborator

@DedeHai DedeHai commented Apr 23, 2025

char value was changed from "55" to 'A' which is 65. need to deduct 10 so the result is 'A' if index counter is 10.

@netmindz this bugfix also needs to go into 0.15.x if approved by @blazoncek

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the calculation of parameter key and form element suffix characters for bus indices 10 and above, ensuring correct labeling and display for advanced LED settings. This affects how certain settings are represented in both the user interface and JavaScript output.

char value was changed from "55" to 'A' which is 65.
need to deduct 10 so the result is 'A' if index counter is 10.
@DedeHai DedeHai added this to the 0.15.1 candidate milestone Apr 23, 2025
@DedeHai DedeHai requested a review from blazoncek April 23, 2025 04:35
Copy link
Contributor

coderabbitai bot commented Apr 23, 2025

Walkthrough

The changes adjust how ASCII offsets are calculated for generating parameter keys and suffix characters associated with buses, color order mappings, and buttons in two files. Specifically, for indices 10 and above, the ASCII offset is now set to 'A' - 10 instead of 'A'. This modification affects the character used in parameter keys and form element IDs for these indices within loops that iterate over buses, color orders, and buttons. No other logic, error handling, or exported/public entity declarations are modified.

Changes

Files Change Summary
wled00/set.cpp, wled00/xml.cpp Updated the calculation of the ASCII offset for indices ≥10 in loops generating parameter keys and suffix characters, shifting the offset from 'A' to 'A' - 10. No other logic or declarations changed.

Suggested reviewers

  • blazoncek
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3538684 and dd0c05d.

📒 Files selected for processing (2)
  • wled00/set.cpp (3 hunks)
  • wled00/xml.cpp (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: wled_build / Build Environments (esp32s3_4M_qspi)
  • GitHub Check: wled_build / Build Environments (esp32s3dev_16MB_opi)
  • GitHub Check: wled_build / Build Environments (esp32dev_V4)
  • GitHub Check: wled_build / Build Environments (lolin_s2_mini)
  • GitHub Check: wled_build / Build Environments (esp32s3dev_8MB_opi)
  • GitHub Check: wled_build / Build Environments (usermods)
  • GitHub Check: wled_build / Build Environments (esp32_wrover)
  • GitHub Check: wled_build / Build Environments (nodemcuv2_160)
  • GitHub Check: wled_build / Build Environments (esp32dev)
  • GitHub Check: wled_build / Build Environments (nodemcuv2_compat)

@DedeHai DedeHai changed the title fix bug in enumerating buttons and busses bugfix in enumerating buttons and busses Apr 23, 2025
Copy link
Collaborator

@blazoncek blazoncek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
@DedeHai once merged just chery-pick into 0_15_x branch.

@DedeHai DedeHai merged commit 10b925a into wled:main Apr 23, 2025
21 checks passed
blazoncek pushed a commit to blazoncek/WLED that referenced this pull request Apr 23, 2025
char value was changed from "55" to 'A' which is 65.
need to deduct 10 so the result is 'A' if index counter is 10.
DedeHai added a commit that referenced this pull request Apr 26, 2025
char value was changed from "55" to 'A' which is 65.
need to deduct 10 so the result is 'A' if index counter is 10.
blazoncek pushed a commit to blazoncek/WLED that referenced this pull request Apr 27, 2025
char value was changed from "55" to 'A' which is 65.
need to deduct 10 so the result is 'A' if index counter is 10.
@DedeHai DedeHai deleted the enumartion_bugfix branch April 27, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants