gradient support! #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is huge! Thanks a ton for the PR. Feel free to ping me directly when it's ready for review |
| @@ -27,6 +27,20 @@ struct fx_gles_render_pass *fx_renderer_begin_buffer_pass(struct wlr_renderer *w | |||
| struct wlr_buffer *wlr_buffer, struct wlr_output *output, | |||
| const struct wlr_buffer_pass_options *options); | |||
|
|
|||
| struct fx_gradient { | |||
| float degree; | |||
There was a problem hiding this comment.
What are the bounds of this?
|
|
||
| float rad = radians(degree); | ||
|
|
||
| if(linear){ |
There was a problem hiding this comment.
Nit: please match the bracket spacing throughout the shaders here with the existing format we have in our other shaders
WillPower3309
approved these changes
Oct 28, 2024
|
lets go it got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
fx_render_pass_add_rect_grad,fx_render_pass_add_rounded_rect_grad, andfx_render_pass_add_rounded_grad_border_corner. all with associated shaders, structs, and linking functions.all gradients support as many colors as you want (dynamic shader compilation), linear/conic variants, and rotation (in degrees)