Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Enhancement: Add Footer Template Part #6596

Merged
merged 9 commits into from
Jun 22, 2022
Merged

Enhancement: Add Footer Template Part #6596

merged 9 commits into from
Jun 22, 2022

Conversation

masteradhoc
Copy link
Contributor

@masteradhoc masteradhoc commented Jun 18, 2022

Describe the bug

See #6197

Changes in the PR

Footer template part that on all woo pages uses now <footer class="wp-block-template-part"> instead of <div class="wp-block-template-part">.

Header template part that on woo pages uses now <header class="wp-block-template-part"> instead of <div class="wp-block-template-part">.

Fixes #6197

Screenshots

Before:

After:

User Facing Testing

  1. Go to a Woo page and view the source.
  2. Check the header is wrapped in a <header> tag, not in a <div>.
  3. Check the footer is wrapped in a <footer> tag, not in <div>.

WooCommerce Visibility

no visible changes in this PR

Performance Impact

no Performance Impacts

Changelog

Enhancement: Footer Template Parts use now <footer> instead of <div> and Header uses <header> instead of <div>.

@Aljullu Aljullu requested review from a team and albarin and removed request for a team June 21, 2022 11:49
@Aljullu Aljullu added status: needs review focus: FSE Work related to prepare WooCommerce for FSE. labels Jun 21, 2022
@albarin
Copy link
Contributor

albarin commented Jun 21, 2022

Hey @masteradhoc, thanks a lot for your contribution!
Would be really helpful for us if you could complete the PR description according to the PR template. Feel free to delete the sections that don't apply to your changes. Please let us know if you have any doubts or if we can help you with something.
Thanks again! 😄

@albarin albarin merged commit fa2bc57 into woocommerce:trunk Jun 22, 2022
@nielslange nielslange added this to the 8.0.0 milestone Jul 4, 2022
@nielslange nielslange added the type: enhancement The issue is a request for an enhancement. label Jul 4, 2022
@nielslange nielslange changed the title Add Footer Template Part Enhancement: Add Footer Template Part Jul 4, 2022
@masteradhoc masteradhoc deleted the footer-tagname branch July 24, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: FSE Work related to prepare WooCommerce for FSE. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer template part not using <footer> tag
4 participants