This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Improve the performance of checking payment methods #7413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
a team and
tarhi-saad
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
|
Size Change: -55 B (0%) Total Size: 992 kB
ℹ️ View Unchanged
|
opr
suggested changes
Oct 19, 2022
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
opr
force-pushed
the
fix/too-many-calls-too-check-payment-methods-can-pay
branch
from
959cbc6 to
cefcd67
Compare
|
This branch has some conflicts |
|
@alexflorisca does this close #7031? If so, let's add this info in the description |
It's already in the description. I'll catch up with @opr about this today and wrap it up |
alexflorisca
force-pushed
the
fix/too-many-calls-too-check-payment-methods-can-pay
branch
from
cefcd67 to
45a1f25
Compare
alexflorisca
commented
Oct 25, 2022
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { STORE_KEY as PAYMENT_STORE_KEY } from '../payment/constants'; |
There was a problem hiding this comment.
Need to import from constants here to avoid circular dependency
opr
approved these changes
Oct 25, 2022
|
Cool, E2E tests seem unrelated so merging |
alexflorisca
deleted the
fix/too-many-calls-too-check-payment-methods-can-pay
branch
7 tasks
albarin
added
the
skip-changelog
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Improve the performance of checking payment methods * Use the default names of imports from @wordpress/data * Fix circular dependency * Fix __internalUpdateAvailablePaymentMethods Co-authored-by: Thomas Roberts <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve performance of the C & C blocks by reducing the number of times we check that each payment method can pay. After the data store migration, we call
checkPaymentMethodsCanPayfor each change to the cart store. This is a function that does a lot of heavy processing (calls thecanPaymethod for each payment method registered on the store). It was being run 4 times for standard payment methods, and 4 for express payment methods just on loading the cart page.I've done 2 things here:
__internalInitializePaymentStorefunction to__internalUpdateAvailablePaymentMethodsto better reflect what it's doing. It now checks if the payment methods have been initialised and only calls the action to initialize them if they haven't. This allows us to call this function from a.subscribe()function without worrying that the__internalSetPaymentMethodsInitializedand__internalSetExpressPaymentMethodsInitializedwill be called multiple times.Fixes #7031
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
This should speed things up slightly on the front-end