Skip to content

Add wc com disconnect command #33999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 15, 2022
Merged

Add wc com disconnect command #33999

merged 5 commits into from
Aug 15, 2022

Conversation

rcstr
Copy link
Contributor

@rcstr rcstr commented Jul 20, 2022 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Closes https://github.com/Automattic/woocommerce.com/issues/13870.

How to test the changes in this Pull Request:

  1. Having a test site connected to WooCommerce.com ('http://localhost/wp-admin/admin.php?page=wc-addons&section=helper')
  2. From terminal run wp wc com disconnect, the site should be disconnected

Screen Shot 2022-07-20 at 10 50 46

  1. Confirm from 'http://localhost/wp-admin/admin.php?page=wc-addons&section=helper' that the site is correctly disconnected and that the connect screen is shown

Screen Shot 2022-07-20 at 10 51 48

  1. From the terminal, run wp wc com disconnect again. An error message should be shown

Screen Shot 2022-07-20 at 10 52 38

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 20, 2022
@rcstr rcstr requested a review from thilinah July 20, 2022 14:32
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2022 •
edited
Loading

Test Results Summary

Commit SHA: d8ca7ce

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests11500201170m 43s
E2E Tests185001018614m 23s
 To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rcstr rcstr force-pushed the add/wc-com-disconnect-command branch from f8e2377 to a763668 Compare July 20, 2022 16:41
@rcstr rcstr requested review from a team and jorgeatorres and removed request for a team July 20, 2022 16:49
@rcstr rcstr marked this pull request as ready for review July 20, 2022 16:53
@rcstr rcstr changed the title Add/wc com disconnect command Add wc com disconnect command Jul 20, 2022
@rcstr rcstr self-assigned this Jul 20, 2022
@rcstr rcstr force-pushed the add/wc-com-disconnect-command branch from 7e01512 to d8ca7ce Compare July 20, 2022 20:15
@rcstr rcstr added this to the 6.9.0 milestone Jul 20, 2022
thilinah
thilinah approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@thilinah thilinah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine. LGTM !

jorgeatorres
jorgeatorres approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@jorgeatorres jorgeatorres left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢. Thanks @rcstr!

@jorgeatorres jorgeatorres merged commit 2ab9398 into trunk Aug 15, 2022
@jorgeatorres jorgeatorres deleted the add/wc-com-disconnect-command branch August 15, 2022 12:54
@github-actions
Copy link
Contributor

Hi @jorgeatorres, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

rcstr added a commit that referenced this pull request Aug 16, 2022
@rcstr
Merge branch 'trunk' into add/wc-com-connect-command
0acce56 
* trunk: (97 commits)
  [COT] Respect status flags `show_in_admin_(all|status)_list` in orders list table (#34290)
  Fix a bug crashing wp-env 5.1.0 in CI (#34274)
  Add unit tests for orders milestone note (#34295)
  Update "context" prop of task list click/view event (#34297)
  Update the cherry-pick workflow to not run for non-existent branches (#34325)
  Update CI to use wp-env for api, e2e and performance tests (#34311)
  Clear post cache after updating menu order for products. (#34195)
  Add `wc com disconnect` command (#33999)
  Fix review shipping option task title (#34294)
  Add Facebook Extension to Onboarding (#34303)
  Add Media Uploader component (#34181)
  Add SortableList component (#34237)
  Change to use fetch depth 0 (#34288)
  Add SplitDropdown component (#34180)
  Fix/forgotten template version (#34308)
  Fix/34271 unlimited results (#34289)
  Add product name and checkboxes for Product details (#34214)
  Prepare Packages for Release (#34299)
  dev: move guided tours into consolidated folder (#34279)
  Add flag to state it is in dev mode so tools are installed like phpun… (#34258)
  ...

 Conflicts:
	plugins/woocommerce/includes/admin/helper/class-wc-helper.php
	plugins/woocommerce/includes/cli/class-wc-cli-com-command.php
@github-actions github-actions bot mentioned this pull request Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeatorres jorgeatorres jorgeatorres approved these changes

@thilinah thilinah thilinah approved these changes

Assignees

@rcstr rcstr

Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Milestone
6.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rcstr @jorgeatorres @thilinah