Update all the placeholders on content change #1032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
The PlaceholderManager contained an optimization that would only update placeholders after the selection start on content change. This works normally fine. However, there is an issue when typing with gestures. Since the inserted word moves the selection start further, the placeholder right after the word wasn't updated. As a fix I've removed this optimization. If we notice any performance issues, we can be smarter about it (and for example only update everything after the previous linebreak).
Test
MainActivity
with thePlaceholderManager
. For this you need to initialize the manager and register it with Aztec. Create aImageWithCaptionAdapter
instance and register it with thePlaceholderManager
. Replace theEXAMPLE_HTML
content with something like<placeholder type=\"image_with_caption\" src=\"and_valid_image_url\" caption=\"test\"></placeholder>
aztec.mp4
Review
@khaykov
Make sure strings will be translated:
strings.xml
as a part of the integration PR.