Discover the login url for self-hosted sites and log it #21851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new mechanism to discover and log the authorization URL for self-hosted sites during the login process.
- Adds a new LoginSiteAddressViewModel with API discovery logic.
- Integrates the view model into the LoginSiteAddressFragment.
- Updates dependency injection modules to bind the new view model and provide a singleton WpLoginClient.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libs/login/src/main/java/org/wordpress/android/login/viewmodel/LoginSiteAddressViewModel.kt | Implements API discovery and logs the discovered authorization URL. |
| libs/login/src/main/java/org/wordpress/android/login/LoginSiteAddressFragment.kt | Initializes the new view model and invokes the API discovery. |
| WordPress/src/main/java/org/wordpress/android/modules/ViewModelModule.java | Adds binding for LoginSiteAddressViewModel. |
| WordPress/src/main/java/org/wordpress/android/modules/ApplicationModule.java | Provides a singleton instance of WpLoginClient. |
Files not reviewed (1)
- libs/login/build.gradle: Language not supported
libs/login/src/main/java/org/wordpress/android/login/viewmodel/LoginSiteAddressViewModel.kt
Show resolved
Hide resolved
Generated by 🚫 Danger |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21851-2f68298 | |
| Commit | 2f68298 | |
| Direct Download | jetpack-prototype-build-pr21851-2f68298.apk |
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21851-2f68298 | |
| Commit | 2f68298 | |
| Direct Download | wordpress-prototype-build-pr21851-2f68298.apk |
…r-the-login-url-and-log-it
nbradbury
reviewed
May 1, 2025
| val authorizationUrl = urlDiscovery.apiDetails.findApplicationPasswordsAuthenticationUrl() | ||
| Log.d("WP_RS", "VM: Found authorization URL: $authorizationUrl") | ||
| } catch (throwable: Throwable) { | ||
| Log.e("WP_RS", "VM: Error during API discovery", throwable) |
There was a problem hiding this comment.
I'm wondering if we should include the passed url in the log message?
There was a problem hiding this comment.
This logic is not gonna exist in the way it is in the next iteration. The logging is actually just to check the PR, so I don't think it's necessary.
nbradbury
reviewed
May 1, 2025
| @@ -190,6 +198,8 @@ class LoginSiteAddressFragment : LoginBaseDiscoveryFragment(), TextWatcher, OnEd | |||
|
|
|||
| val cleanedUrl = stripKnownPaths(requestedSiteAddress.orEmpty()) | |||
|
|
|||
| viewModel.runApiDiscovery(cleanedUrl) | |||
There was a problem hiding this comment.
Nitpick: maybe add a comment that this is a work-in-progress and isn't really used yet?
nbradbury
approved these changes
May 1, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is discovering the password login url for a site and logging it
Testing instructions