-
Notifications
You must be signed in to change notification settings - Fork 2
chore: DRAFT - Add test to Previews and setup test workflow for plugins #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
I think it may be time for some caching optimizations. You can check out how I do this with Node on the Faust repo. Basically, I install & set up Node, install dependencies, then the disk is cached under a unique hash based on the state of Looks like at least composer install, if not some wider PHP config, could be configured to only happen once, and then have PHPCS, tests, and artifact creation all do cache restores. |
Thanks @moonmeister ❤️ Thanks for the great feedback. I will have a look tomorrow at how you setup caching on Faust and look at making some optimizations. |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
ℹ️ Download the hwp-previews plugin artifact from this workflow run (see the 'Artifacts' section at the bottom). |
Description
Related Issue
Dependant PRs
Type of Change
How Has This Been Tested?
Screenshots
Checklist