Skip to content

Introduce LIST value type for rule evaluation #6713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

osandamaleesha
Copy link
Contributor

@osandamaleesha osandamaleesha commented May 7, 2025

Proposed changes

  • This PR introduces the LIST value type for the rule evaluation FieldValue which supports to provide List typed evaluation data.
  • In addition this PR adds relevant unit tests for the added LIST value type.

Related issue in product-is

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.15%. Comparing base (bcf3476) to head (918e0db).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
...valuation/internal/service/impl/RuleEvaluator.java 50.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6713      +/-   ##
============================================
- Coverage     48.28%   48.15%   -0.14%     
- Complexity    16292    16313      +21     
============================================
  Files          1838     1839       +1     
  Lines        108941   109493     +552     
  Branches      20769    20878     +109     
============================================
+ Hits          52606    52730     +124     
- Misses        49161    49577     +416     
- Partials       7174     7186      +12     
Flag Coverage Δ
unit 32.07% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

sonarqubecloud bot commented May 7, 2025

@indeewari indeewari merged commit b6a2999 into wso2:master May 7, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants