Release 1.1.60

[eddelbuettel]

This PR prepares 1.1.60.

I made a final change simplifying the one tests (which we only need to run once) but also adding a reference output of 'success' so that R will fail a check if this fails to match. It uses the old-old trick of storing the test output as a file ending in .Rout.save.

And I made a quick attempt at backfilling the ChangeLog. Improvements to that are of course welcome too.

I won't upload until a get a 'thumbs up' approval, and I suggest to not merge until this is on CRAN allowing for any last minute change the CRAN team may require. That pattern of 'holding' the new release PR has worked well for me in many other package contexts.

[christophsax]

Looks good, thanks a lot!

And still compiles and passes the checks on my Mac.

[eddelbuettel]

Yes I have of course also been running r-devel checks here etc. But as we need an eye on different builds, the r-universe aggregate may be best.

So ok to pack it up and ship it to CRAN ?

[christophsax]

I think so, looks good to me!

[eddelbuettel]

I need one more check. Eye-balling the DESCRIPTION file I just noticed that it e.g. dropped Jeroen as 'ctb'. I must have flattened an earlier commit away which is moderately worrisome. One sec.

[eddelbuettel]

Ok, I appear to have 'lost' #79 but that was just a single commit which I cherry-picked back and pushed. I did eyeball all the changes of the other PRs and they are there. So my bad for bumbling one micro-change, and lucky me I caught it...

[eddelbuettel]

And we fell into a Kurt Hornik-shaped hole:

Dear maintainer,

package x13binary_1.1.60.tar.gz does not pass the incoming checks automatically, please see the following pre-tests:
Windows: <https://win-builder.r-project.org/incoming_pretest/x13binary_1.1.60_20240121_173957/Windows/00check.log>
Status: OK
Debian: <https://win-builder.r-project.org/incoming_pretest/x13binary_1.1.60_20240121_173957/Debian/00check.log>
Status: 1 ERROR

Last released version's CRAN status: OK: 8, NOTE: 4
See: <https://CRAN.R-project.org/web/checks/check_results_x13binary.html>

CRAN Web: <https://cran.r-project.org/package=x13binary>

Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help on the R-package-devel mailing list:
<https://stat.ethz.ch/mailman/listinfo/r-package-devel>
If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.

More details are given in the directory:
<https://win-builder.r-project.org/incoming_pretest/x13binary_1.1.60_20240121_173957/>
The files will be removed after roughly 7 days.

*** Strong rev. depends ***: gunsales seasonal x12

Best regards,
CRAN teams' auto-check service

[-- Attachment #2: "00details.log" --]                                                                                                                                                                             
[-- Type: text/plain, Encoding: 7bit, Size: 0.4K --]                                                                                                                                                               

Flavor: r-devel-linux-x86_64-debian-gcc, r-devel-windows-x86_64
Check: CRAN incoming feasibility, Result: Note_to_CRAN_maintainers
  Maintainer: 'Dirk Eddelbuettel <[email protected]>'

Flavor: r-devel-linux-x86_64-debian-gcc
Check: whether package can be installed, Result: ERROR
  Installation failed.
  See '/srv/hornik/tmp/CRAN/x13binary.Rcheck/00install.out' for details.

@kurthornik I know of course it is Sunday but the above does not lead to any downloadable logs. It ends for me in

* using log directory ‘/srv/hornik/tmp/CRAN/x13binary.Rcheck’
* using R Under development (unstable) (2024-01-20 r85814)
* using platform: x86_64-pc-linux-gnu
* R was compiled by
    Debian clang version 17.0.6 (3)
    Debian flang-new version 17.0.6 (3)
* running under: Debian GNU/Linux trixie/sid
* using session charset: UTF-8
* checking for file ‘x13binary/DESCRIPTION’ ... OK
* checking extension type ... Package
* this is package ‘x13binary’ version ‘1.1.60’
* package encoding: UTF-8
* checking CRAN incoming feasibility ... [3s/6s] Note_to_CRAN_maintainers
Maintainer: ‘Dirk Eddelbuettel <[email protected]>’
* checking package namespace information ... OK
* checking package dependencies ... OK
* checking if this is a source package ... OK
* checking if there is a namespace ... OK
* checking for executable files ... OK
* checking for hidden files and directories ... OK
* checking for portable file names ... OK
* checking for sufficient/correct file permissions ... OK
* checking serialization versions ... OK
* checking whether package ‘x13binary’ can be installed ... [209s/105s] ERROR
Installation failed.
See ‘/srv/hornik/tmp/CRAN/x13binary.Rcheck/00install.out’ for details.
* DONE
Status: 1 ERROR

and I don't have 00install.out. The (now enlarged) team of five of us has been banging at his for a few month now and I do not think we have seen a single build failure. I will fire up a Debian container now, on Ubuntu (23.10, 22.04 at CI and for others) it "just works" ...

[eddelbuettel]

Installs like a champ in rocker/r-base aka Debian testing (with apt update -qq; apt upgrade -y):

root@c7f033d53ec3:/work# install.r x13binary_1.1.60.tar.gz    # wrapper for `install.packages()`
* installing *source* package ‘x13binary’ ...                                                            
** using staged installation                  
** libs                             
FC="gfortran" LINKER="gcc" LDFLAGS="-lgfortran -lm -lquadmath" make --directory=../tools/x13as_html -f makefile.gf x13ashtml
make[1]: Entering directory '/tmp/RtmpM1Nma6/R.INSTALL12f86fae539e/x13binary/tools/x13as_html'
gfortran   -c -o aaamain.o aaamain.f
gfortran   -c -o abend.o abend.f  
gfortran   -c -o acf.o acf.f                                                                             
gfortran   -c -o acfar.o acfar.f                                                                         
gfortran   -c -o acfdgn.o acfdgn.f           
# ... several dozen similar lines skipped ...
gfortran   -c -o gennpsa.o gennpsa.f
gfortran   -c -o prarma.o prarma.f
gfortran   -c -o testodf.o testodf.f
gcc -o x13ashtml aaamain.o abend.o acf.o acfar.o acfdgn.o acfhdr.o addadj.o addate.o addeas.o addfix.o addlom.o addmat.o addmul.o addotl.o addsef.o addsub.o addtd.o addusr.o adestr.o adjreg.o adjsrs.o adlabr.o adotss.o adpdrg.o adrgef.o adrgim.o adsncs.o adthnk.o aggmea.o agr.o agr1.o agr2.o agr3.o agr3s.o agrxpt.o altundovrtst.o amdest.o amdfct.o amdid.o amdid2.o amdprt.o amidot.o analts.o ansub1.o ansub10.o ansub11.o ansub2.o ansub3.o ansub4.o ansub5.o ansub7.o ansub8.o ansub9.o antilg.o apply.o ar30rg.o arfit.o arflt.o arima.o armacr.o armafl.o armats.o arspc.o autoer.o automd.o automx.o avedur.o aver.o averag.o bakusr.o bench.o bestmd.o bkdfmd.o bldcov.o blddif.o bstget.o bstmdl.o btrit.o calcqs.o calcqs2.o calcsc.o ceilng.o change.o chisq.o chitst.o chkadj.o chkchi.o chkcvr.o chkeas.o chkmu.o chkorv.o chkrt1.o chkrt2.o chkrts.o chksmd.o chktrn.o chkuhg.o chkurt.o chkzro.o chrt.o chsppf.o chusrg.o clrotl.o clsgrp.o cmpchi.o cmpstr.o cncrnt.o cnvfil.o cnvfmt.o cnvmdl.o coladd.o combft.o compb.o compcrodiag.o compdiag.o complagdiag.o compmse.o compmsealt.o component.o comprevs.o constant.o copy.o copycl.o copylg.o cormtx.o cornom.o corplt.o covar.o cpyint.o cpymat.o crosco.o ctod.o ctodat.o ctoi.o cumnor.o cvcmma.o cvdttm.o cvrerr.o daxpy.o dcopy.o ddot.o decibl.o delstr.o deltst.o desreg.o devlpl.o dfdate.o dgefa.o dgesl.o difflt.o dinvnr.o divgud.o divsub.o dlrgef.o dlrgrw.o dlusrg.o dot.o dpeq.o dpmpar.o dppdi.o dppfa.o dppsl.o dsarma.o dscal.o dsolve.o dtoc.o easaic.o easter.o editor.o eltfcn.o eltlen.o emcomp.o ends.o endsf.o enorm.o entsch.o errhdr.o estrmu.o euclid.o exctma.o extend.o extsgnl.o f3cal.o f3gen.o fclose.o fcnar.o fcstxy.o fdjac2.o fgen.o fis.o fopen.o forcst.o fouger.o fstop.o ftest.o fvalue.o fxshfr.o gauss.o gendff.o genfoot.o genfor.o genindex.o genqs.o genrtt.o genskip.o genssm.o getadj.o getchk.o getchr.o getcmp.o getdat.o getdbl.o getdes.o getdiag.o getfcn.o getfrc.o getgr.o getid.o getidm.o getint.o getivc.o getmdl.o getmtd.o getopr.o getprt.o getreg.o getrev.o getrevdec.o getsav.o getsma.o getsmat.o getsrs.o getssp.o getstr.o getsvec.o getsvl.o gettpltz.o gettr.o gettrc.o getttl.o getx11.o getxop.o getxtd.o glbshk.o gnfcrv.o grzlst.o grzmth.o grzmyr.o gtarg.o gtarma.o gtauto.o gtautx.o gtdcnm.o gtdcvc.o gtdpvc.o gtdtvc.o gtedit.o gtestm.o gtfcst.o gtfldt.o gtfrcm.o gtfree.o gtinpt.o gtinvl.o gtmdfl.o gtmtdt.o gtmtfl.o gtnmvc.o gtotlr.o gtpdrg.o gtrgdt.o gtrgpt.o gtrgvl.o gtrvst.o gtseat.o gtspec.o gttrmo.o gtwacf.o gtx11d.o gtx12s.o gtxreg.o hender.o hinge.o hist.o histx.o hndend.o hndtrn.o holday.o holidy.o hrest.o htmlfortable.o htmlout.o htmlutil.o idamax.o iddiff.o idmdl.o idotlr.o idpeak.o inbtwn.o indx.o initdg.o initst.o inpter.o insdbl.o insint.o inslg.o insopr.o insort.o insptr.o insstr.o intfmt.o intgpg.o intinp.o intlst.o intrpp.o intsrt.o invfcn.o invmat.o ipmpar.o iscrfn.o isdate.o isfals.o isfixd.o ispeak.o ispos.o issame.o istrue.o itoc.o itrerr.o kfcn.o kwtest.o lassol.o lendp.o lex.o lgnrmc.o lkshnk.o lmdif.o lmpar.o loadxr.o locshk.o logar.o logdet.o lomaic.o lstpth.o makadj.o makotl.o makttl.o map.o matrix.o maxidx.o maxlag.o maxvec.o mdlchk.o mdlfix.o mdlinp.o mdlint.o mdlmch.o mdlset.o mdssln.o meancra.o medabs.o mflag.o minim2.o mkback.o mkealb.o mkfreq.o mklnlb.o mkmdsn.o mkmdsx.o mkmetahtmlfile.o mkoprt.o mkotky.o mkpeak.o mkshdr.o mkspky.o mksplb.o mkssky.o mkstlb.o mkspst.o mktdlb.o mlist.o mltpos.o month.o mstest.o mulmat.o mulqmat.o mulref.o mulsca.o mult.o mult0.o mult1.o mult2.o mxpeak.o nblank.o newest.o nextk.o nmlmdl.o nofcst.o nrmtst.o numaff.o numfmt.o olsreg.o opnfil.o otsort.o outchr.o pacf.o pass0.o pass2.o pctrit.o phasegain.o polyml.o polynom.o ppnd.o pracf2.o prafce.o pragr2.o prfcrv.o pritd.o prlkhd.o procflts.o prothd.o prprad.o prrvob.o prshd2.o prtacf.o prtadj.o prtagr.o prtamd.o prtchi.o prtcol.o prtd8b.o prtd9a.o prtdtb.o prtdwr.o prterr.o prterx.o prtf2.o prtf2w.o prtfct.o prtft.o prtitr.o prtlog.o prtmdl.o prtmsp.o prtmsr.o prtmtx.o prtnfn.o prtopt.o prtref.o prtrev.o prtrts.o prtrv2.o prtshd.o prttbl.o prttbl1.o prttd.o prttrn.o prtxrg.o punch.o putbak.o putrev.o putstr.o qcmmnt.o qcontr.o qdoble.o qintgr.o qmap.o qmap2.o qname.o qquote.o qrfac.o qrsolv.o qsdiff.o qtoken.o quad.o quadit.o quadsd.o ratneg.o ratpos.o rdotlr.o rdotls.o rdregm.o realit.o regfix.o reglbl.o regvar.o regx11.o replac.o replyf.o resid.o resid2.o restor.o revchk.o revdrv.o revhdr.o revrse.o rgarma.o rgtdhl.o rho2.o rmatot.o rmfix.o rmlnvr.o rmlpyr.o rmotrv.o rmotss.o rmpadj.o rmtadj.o rndsa.o rngbuf.o roots.o round.o rplus.o rpoly.o rv2ss.o rvfixd.o rvrghd.o sautco.o savacf.o savchi.o savd8b.o savitr.o savmdc.o savmdl.o savmtx.o savotl.o savpk.o savspp.o savstp.o savtbl.o savwkf.o sceast.o scrmlt.o sdev.o sdxtrm.o seatad.o seatdg.o seatfc.o seatpr.o serates.o setadj.o setamx.o setapt.o setchr.o setcv.o setcvl.o setdp.o setint.o setlg.o setmdl.o setmv.o setopr.o setpt.o setrvp.o setspn.o setssp.o setup.o setwrt.o setxpt.o sfmax.o sfmsr.o sftest.o shlsrt.o shrink.o si.o sicp2.o sigex.o sigsub.o simul.o skparg.o skparm.o skpfcn.o skplst.o smeadl.o smpeak.o snrasp.o spcdrv.o spcrsd.o special.o specpeak.o spectrum.o spgrh.o spgrh2.o spmpar.o ss2rv.o ssap.o ssfnot.o ssftst.o sshist.o ssmdl.o ssort.o sspdrv.o ssphdr.o ssprep.o ssrit.o ssrng.o ssx11a.o ssxmdl.o stpitr.o strinx.o strtvl.o stvaln.o subset.o sumf.o sumry.o sumsqr.o svaict.o svamcm.o svchsd.o svdttm.o svf2f3.o svflt.o svfltd.o svfnrg.o svfreq.o svolit.o svoudg.o svpeak.o svrgcm.o svrvhd.o svspan.o table.o taper.o tblhdr.o td6var.o td7var.o tdaic.o tdftest.o tdlom.o tdset.o tdxtrm.o templs.o tfmts.o tfmts3.o totals.o transc.o trbias.o trnaic.o trnfcn.o tstdrv.o tstmd1.o tstmd2.o ttest.o uconv.o upespm.o usraic.o value.o varian.o varlog.o vars.o vsfa.o vsfb.o vsfc.o vtc.o vtest.o weight.o whitsp.o writln.o wrtdat.o wrtmss.o wrtotl.o wrttb2.o wrttbl.o wtxtrm.o x11aic.o x11ari.o x11int.o x11mdl.o x11plt.o x11pt1.o x11pt2.o x11pt3.o x11pt4.o x11ref.o x12hdr.o x12run.o xchng.o xpand.o xprmx.o xrgdiv.o xrgdrv.o xrghol.o xrgtrn.o xrlkhd.o xtrm.o yprmy.o yrly.o rvarma.o rvtdrg.o prtukp.o svtukp.o savtpk.o m2q.o chqsea.o npsa.o gennpsa.o prarma.o testodf.o   -lgfortran -lm -lquadmath
make[1]: Leaving directory '/tmp/RtmpM1Nma6/R.INSTALL12f86fae539e/x13binary/tools/x13as_html'
mkdir -p ../inst/bin
cp -f ../tools/x13as_html/x13ashtml ../inst/bin/
installing via 'install.libs.R' to /usr/local/lib/R/site-library/00LOCK-x13binary/00new/x13binary
** R
** inst
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
** testing if installed package can be loaded from final location
** testing if installed package keeps a record of temporary installation path
* DONE (x13binary)
root@c7f033d53ec3:/work# 
root@c7f033d53ec3:/work# Rscript -e 'utils::osVersion'
[1] "Debian GNU/Linux trixie/sid"
root@c7f033d53ec3:/work# 

[jeroen]

There is https://win-builder.r-project.org/incoming_pretest/x13binary_1.1.60_20240121_173957/Debian/00install.out

Which ends with

/usr/bin/ld: aaamain.o: in function `_QQmain':
FIRModule:(.text+0x2aa): undefined reference to `fdate_'
/usr/bin/ld: FIRModule:(.text+0x1c74): undefined reference to `fdate_'
/usr/bin/ld: agr3.o: in function `agr3_':
FIRModule:(.text+0x22c): undefined reference to `fdate_'
/usr/bin/ld: agr3s.o: in function `agr3s_':
FIRModule:(.text+0x2bf): undefined reference to `fdate_'
clang-17: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [makefile.gf:286: x13ashtml] Error 1
make[1]: Leaving directory '/srv/hornik/tmp/CRAN/x13binary.Rcheck/00_pkg_src/x13binary/tools/x13as_html'

They seem to be using llvm=17 with flang-new-17. I don't know anything about fortran but it looks like fdate is a GNU extension?

[eddelbuettel]

Hm, where is that linked from / how did I miss that after all those years and being familiar with the mail format?

Bug agreed. Line before the block you quoted end has -lFortran_main -lFortranRuntime -lFortranDecimal and it seems like fortran libs aren't all there yet?

[jeroen]

I think the fdate() extension was only added to flang last november: llvm/llvm-project#71222 so it probably won't be available until CRAN updates to llvm-18. So hopefully Kurt can grant you an exception until then.

[eddelbuettel]

Thanks, @jeroen. I tried to make sense of things in a container, current to Debian testing just like the Vienna setup, but to no avail.

@kurthornik If you can find a few minutes, please give the package a good look. It would us all ahead a good step from the current practice relying on binaries. If and when you keep the default Fortran compiler in Debian testing (or Ubuntu LTS or newer) it 'just works'. Would we nice if we could opt into your standard compiler as opposed to the bleeding edge one.

[jeroen]

Added workaround here: #82

[eddelbuettel]

Merging now as we crossed the finish line:

Dear maintainer,

thanks, package x13binary_1.1.60.tar.gz is on its way to CRAN.

Best regards,
CRAN teams' auto-check service

Big big thanks to everybody. This package is now in much better shape, and we solved a buildability puzzle or two as well.