Skip to content

(backport) http-lib: log reason that causes lack of response #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion http-svr/http_client.ml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ let response_of_fd_exn fd =

(** [response_of_fd fd] returns an optional Http.Response.t record *)
let response_of_fd ?(use_fastpath = false) fd =
let __FUN = "Http_client.response_of_fd" in
try
if use_fastpath then
Some (response_of_fd_exn fd)
Expand All @@ -189,7 +190,12 @@ let response_of_fd ?(use_fastpath = false) fd =
with
| Unix.Unix_error (_, _, _) as e ->
raise e
| _ ->
| e ->
Backtrace.is_important e ;
let bt = Backtrace.get e in
Debug.log_backtrace e bt ;
D.debug "%s: returning no response because of the exception: %s" __FUN
(Printexc.to_string e) ;
None

(** See perftest/tests.ml *)
Expand Down
Loading