Skip to content

Commit c69162b

Browse files
authored
CA-388210: SMAPIv3 concurrency: turn on concurrent operations by default (#6140)
It is believed that the deadlocks in SMAPIv3 were caused by VDI.copy operations that attach the same disk RO multiple times in Dom0. With the previous commits we now use a unique identifier and spawn a separate qemu-dp process in the SMAPIv3 plugins, which should prevent the deadlocks and IO errors due to lack of refcounting. We have also identified the source of deadlocks in xapi-storage-plugins, as a missing _qmp_disconnect, so it should now be safe to enable this by default.
2 parents 5f1a59c + 3e36355 commit c69162b

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

ocaml/xapi-storage-script/main.ml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1791,9 +1791,7 @@ let rec diff a b =
17911791
| a :: aa ->
17921792
if List.mem a b then diff aa b else a :: diff aa b
17931793

1794-
(* default false due to bugs in SMAPIv3 plugins,
1795-
once they are fixed this should be set to true *)
1796-
let concurrent = ref false
1794+
let concurrent = ref true
17971795

17981796
type reload = All | Files of string list | Nothing
17991797

0 commit comments

Comments
 (0)