CA-388210: SMAPIv3 concurrency: turn on concurrent operations by default #6140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is believed that the deadlocks in SMAPIv3 were caused by VDI.copy operations that attach the same disk RO multiple times in Dom0. With the previous commits we now use a unique identifier and spawn a separate qemu-dp process in the SMAPIv3 plugins, which should prevent the deadlocks and IO errors due to lack of refcounting. Signed-off-by: Edwin Török <[email protected]>
last-genius
approved these changes
Dec 2, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
See #6140 on feature/perf, this is the equivalent PR for master.
|
won't this be merged as part of the merge from master? |
Vincent-lau
approved these changes
Dec 2, 2024
edwintorok
force-pushed
the
enable/CA-388210
branch
from
f1c3cee to
24f6db6
Compare
Signed-off-by: Edwin Török <[email protected]>
edwintorok
force-pushed
the
enable/CA-388210
branch
from
24f6db6 to
3e36355
Compare
I will, but that might be a larger change (I haven't checked whether master would conflict with current feature/perf or not) |
edwintorok
added a commit
to edwintorok/xen-api
that referenced
this pull request
Dec 10, 2024
…ult (xapi-project#6140) It is believed that the deadlocks in SMAPIv3 were caused by VDI.copy operations that attach the same disk RO multiple times in Dom0. With the previous commits we now use a unique identifier and spawn a separate qemu-dp process in the SMAPIv3 plugins, which should prevent the deadlocks and IO errors due to lack of refcounting. We have also identified the source of deadlocks in xapi-storage-plugins, as a missing _qmp_disconnect, so it should now be safe to enable this by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is believed that the deadlocks in SMAPIv3 were caused by VDI.copy operations that attach the same disk RO multiple times in Dom0.
With the previous commits we now use a unique identifier and spawn a separate qemu-dp process in the SMAPIv3 plugins, which should prevent the deadlocks and IO errors due to lack of refcounting.
We have also identified the source of deadlocks in xapi-storage-plugins, as a missing _qmp_disconnect, so it should now be safe to enable this by default.