CA-400860: make CPU and netdev RRDD plugins pick up changes in domains #6067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When these metrics were collected internally, Xenctrl was queried every 5 seconds. After being split into plugins, they started querying domains (and other information) only on startup, so couldn't pick up new VMs and report their metrics without restarting. Signed-off-by: Andrii Sultanov <[email protected]>
psafont
reviewed
Oct 21, 2024
| @@ -236,8 +237,8 @@ let _ = | |||
| (* Share one page per PCPU and dom each *) | |||
| let physinfo = Xenctrl.physinfo xc in | |||
| let shared_page_count = physinfo.Xenctrl.nr_cpus + List.length domains in | |||
|
|
|||
| (* TODO: Can run out of pages if a lot of domains are added at runtime *) | |||
There was a problem hiding this comment.
better to add a static number that's correlated with the maximum supported number of VMs
There was a problem hiding this comment.
True, but I was worried that might be a bit too much and would need more testing, this quick fix is probably not the place for it
lindig
approved these changes
Oct 21, 2024
psafont
approved these changes
Oct 21, 2024
|
This fixes the regression, tested on a host with a Windows VM, both the CPU and network metrics are present without restarting toolstack. |
|
Have an improvement for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When these metrics were collected internally, Xenctrl was queried every 5 seconds. After being split into plugins, they started querying domains (and other information) only on startup, so couldn't pick up new VMs and report their metrics without restarting.