Skip to content

xenopsd: Avoid calling to_string every time #6206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

xenopsd: Avoid calling to_string every time #6206

merged 1 commit into from
Jan 2, 2025

Conversation

freddy77
Copy link
Collaborator

@freddy77 freddy77 commented Jan 2, 2025

Minor style.

uuid is always converted to string, avoid doing it every time it's used.

@freddy77
xenopsd: Avoid calling to_string every time
75f0b41 
Minor style.
"uuid" is always converted to string, avoid doing it every time it's used.

Signed-off-by: Frediano Ziglio <[email protected]>
contificate
contificate approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@contificate contificate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance, there appears to be other parts of the file where this could be done.

Preferably, if it's only used this way, we could just avoid the shadowing altogether.

@psafont psafont added this pull request to the merge queue Jan 2, 2025
Merged via the queue into xapi-project:master with commit 34b5b63 Jan 2, 2025
15 checks passed
@freddy77 freddy77 deleted the simplify_string branch January 7, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psafont psafont psafont approved these changes

@contificate contificate contificate approved these changes

@robhoes robhoes Awaiting requested review from robhoes

@edwintorok edwintorok Awaiting requested review from edwintorok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freddy77 @psafont @contificate