CA-404236, gencert: when parsing pems, ignore data between key and certificates #6207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
reviewed
Jan 2, 2025
psafont
force-pushed
the
private/paus/pimpampem
branch
from
ce46e81 to
b3d2e58
Compare
edwintorok
approved these changes
Jan 2, 2025
Vincent-lau
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
IIRC this will ignore anything that is present between END----- and -----BEGIN's, but does not handle the situation of things like XXX!! -----BEGIN?
The RFC says
Textual encoding begins with a line comprising "-----BEGIN ",
Not sure if that means -----BEGIN should always be at the start of the line, but maybe it shouldn't
psafont
changed the title
lindig
approved these changes
Jan 6, 2025
The full sentence is
I read it as the line comprises 3 and only 3 elements, excluding others. So the current code would do the right thing |
Helpful for debugging pem-parsing issues Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
private/paus/pimpampem
branch
from
b3d2e58 to
971d753
Compare
…rtificates This is needed in order to be compliant with RFC 7468: https://datatracker.ietf.org/doc/html/rfc7468#section-2 Data before the encapsulation boundaries are permitted, and parsers MUST NOT malfunction when processing such data. Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
private/paus/pimpampem
branch
from
971d753 to
2d84622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA-404236, gencert: when parsing pems, ignore data between key and crrtificates
This is needed in order to be compliant with RFC 7468:
https://datatracker.ietf.org/doc/html/rfc7468#section-2
Data before the encapsulation boundaries are permitted, and parsers MUST NOT
malfunction when processing such data.
Signed-off-by: Pau Ruiz Safont [email protected]