CA-403344: Add db_get_by_uuid_opt to db_cache* #6209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-lau
changed the title
Vincent-lau
force-pushed
the
private/shul2/uuid-opt
branch
from
f3a6a64 to
68df708
Compare
edwintorok
approved these changes
Jan 3, 2025
There was a problem hiding this comment.
The changes look good, but database_test is not run automatically, I see it only called with true for in_process which wouldn't exercise the remote interface.
Have you tried manually running it to confirm that it works? (And that without the bugfix it fails as expected?)
Would be good to also automate running the test, but that can be done in another PR.
Vincent-lau
force-pushed
the
private/shul2/uuid-opt
branch
from
68df708 to
49dc802
Compare
contificate
reviewed
Jan 3, 2025
lindig
approved these changes
Jan 6, 2025
Co-authored-by: Edwin Török <[email protected]> Signed-off-by: Vincent Liu <[email protected]>
Signed-off-by: Vincent Liu <[email protected]>
Signed-off-by: Vincent Liu <[email protected]>
Vincent-lau
force-pushed
the
private/shul2/uuid-opt
branch
from
9d8b29d to
c69aec9
Compare
robhoes
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.