Skip to content

CP-51692: Do not enable Event.next ratelimiting if Event.next is still used internally #6222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ocaml/xapi/xapi_event.ml
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,13 @@ let unregister ~__context ~classes =

(** Blocking call which returns the next set of events relevant to this session. *)
let rec next ~__context =
let batching = !Xapi_globs.event_next_delay in
let batching =
if !Constants.use_event_next then
Throttle.Batching.make ~delay_before:Mtime.Span.zero
~delay_between:Mtime.Span.zero
else
!Xapi_globs.event_next_delay
in
let session = Context.get_session_id __context in
let open Next in
assert_subscribed session ;
Expand Down
Loading