Skip to content

Remove unused function #6241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Remove unused function #6241

merged 1 commit into from
Jan 21, 2025

Conversation

robhoes
Copy link
Member

@robhoes robhoes commented Jan 21, 2025

No description provided.

Signed-off-by: Rob Hoes <[email protected]>
@freddy77
Copy link
Collaborator

I would say Remove unused function -> Remove unused functions

Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If unused, the CI should prove it

Copy link
Contributor

@contificate contificate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge!

@psafont
Copy link
Member

psafont commented Jan 21, 2025

If unused, the CI should prove it

This can be done with an .mli as well

@robhoes
Copy link
Member Author

robhoes commented Jan 21, 2025

Yeah, I did compile it before submitting the PR ;)

@edwintorok edwintorok added this pull request to the merge queue Jan 21, 2025
Merged via the queue into xapi-project:master with commit 4e45833 Jan 21, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants