Simplify some parts of message-switch/unix #6294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More importantly, Mutex.unlock exception's weren't handled Signed-off-by: Pau Ruiz Safont <[email protected]>
The Ivar and CLock modules are unrelated to Cohttp's IO, so move them out. While doing this, add an interface for both. Signed-off-by: Pau Ruiz Safont <[email protected]>
contificate
approved these changes
Feb 12, 2025
lindig
approved these changes
Feb 12, 2025
Only the relative time was ever used, a module was unused, and types could be simpler. Added an interface to make this clear. Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
private/paus/switchy
branch
from
c75fab0 to
19704ac
Compare
|
Removed the ppx preprocessing from dune as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was duplicated and unused code, as well as unnecessarily-nested modules.