Docs on xenopsd: Apply minor fixups to VM.build #6297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the superflous heading for the initial mermaid flowchart - Improve the description above the initial mermaid flowchart - Fix some headings from '# heading text' to '## heading text' - Rephrase the list heading for the platform data in Xenstore Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
- Fix the link to the [NUMA feature description](/toolstack/features/NUMA) - Heading of build_pre: Shorter, less likely to wrap to new line - Rephrase for clarity, move non-essential remarks into parentheses - Avoid `` in [`text`](link): The `text` not visible to be a link Signed-off-by: Bernhard Kaindl <[email protected]>
psafont
approved these changes
Feb 12, 2025
bernhardkaindl
commented
Feb 12, 2025
There was a problem hiding this comment.
Thanks, looks good; I checked the fixes:
- xenopsd/walkthroughs/VM.build/VM_build:
"See the walk-through of the Domain.build function" ... (link fixed) - xenopsd/walkthroughs/VM.build/Domain.build:
"Call the numa_placement function as described in the NUMA feature description" ... - xenopsd/walkthroughs/VM.build/xenguest:
Headings are fixed: They have the proper CSS style and anchor links
lindig
approved these changes
Feb 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bernhardkaindl
commented
Feb 13, 2025
There was a problem hiding this comment.
Coveralls is down for maintenance and
the continue-on-error / fail-on-error: false was missing on one of the coverage upload steps.
As there is not much active work on Python now, it should be fine to not block PR work because of such errors.
@psafont / @lindig: The PR is ready for the merge queue again.
psafont
approved these changes
Feb 13, 2025
|
can this be rebased? we merged a fix for coveralls |
Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
docs-on-xenopsd-apply-minor-fixups-to-VM.build
branch
from
f181d72 to
51e48a6
Compare
@psafont: Fixed the conflict from the merged coveralls upload fix by Edwin |
psafont
approved these changes
Feb 13, 2025
bernhardkaindl
deleted the
docs-on-xenopsd-apply-minor-fixups-to-VM.build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.