CA-407328: Change vm parameter names of SXM calls #6324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vm parameter passed to SMAPIv2 calls is needed for the storage backend to know which domain slice it should operate on. For SXM, since there is no specific VM, we use the convention "MIR<vm-prefix>", where the <vm-prefix> is the first five characters of the hash of the vm uuid. This is not sufficient for VMs with multiple VDIs attached to it as they would result in the same vm parameter. So use a new convention "MIR<vm-prefix><vdi-prefix>" so we distinguish VDIs during migration. These vm parameters cannot be too long though as otherwise the storage backend will not accept them. Signed-off-by: Vincent Liu <[email protected]>
robhoes
approved these changes
Feb 26, 2025
psafont
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vm parameter passed to SMAPIv2 calls is needed for the storage backend to know which domain slice it should operate on. For SXM, since there is no specific VM, we use the convention "MIR", where the is the first five characters of the hash of the vm uuid. This is not sufficient for VMs with multiple VDIs attached to it as they would result in the same vm parameter.
So use a new convention "MIR" so we distinguish VDIs during migration. These vm parameters cannot be too long though as otherwise the storage backend will not accept them.