Skip to content

CP-53708: Expose the existing PCI vendor/device IDs #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

changlei-li
Copy link
Contributor

To facilitate the telemetry purpose, change "*_id" fields in PCI objects from internal_only:true to internal_only:false in xapi.
class_id
vendor_id
device_id
subsystem_vendor_id
subsystem_device_id

To facilitate the telemetry purpose, change "*_id" fields in PCI
objects from internal_only:true to internal_only:false in xapi.
class_id
vendor_id
device_id
subsystem_vendor_id
subsystem_device_id

Signed-off-by: Changlei Li <[email protected]>
Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this strictly necessary and the values are not visible for telemetry otherwise?

@minglumlu
Copy link
Member

Is this strictly necessary and the values are not visible for telemetry otherwise?

The data is expected to be exposed on pool level. It's the most convenient way to get them for all hosts via XAPI interface.

@minglumlu minglumlu added this pull request to the merge queue Feb 28, 2025
Merged via the queue into xapi-project:master with commit a4c058d Feb 28, 2025
15 checks passed
@changlei-li changlei-li deleted the private/changleli/CP-53708 branch March 3, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants